Re: [igt-dev] [PATCH i-g-t] tools/intel_gpu_power: Intel GPU idle/busy power measurement

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 20 Jan 2023 10:00:09 -0800, Kamil Konieczny wrote:
>
> Hi,
>

Hi Kamil,

> On 2023-01-20 at 08:38:31 -0800, Ashutosh Dixit wrote:
> > In several instances (e.g. when investigating GPU power limits) it is very
> > useful to be able to measure GPU power easily. Since we already have all
> > ingredients for doing so, add a tool to measure Intel GPU power when idle
> > and power under load.
> >
> > v2: Use softpin/allocator (Riana)
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> These looks like a test or benchmark, btw intel_gpu_top already
> has printing used power. What we can have is standalone app which
> shows only power consumption every few seconds or some other
> configurable interval, plus maybe for all GPUs if there are more.
>
> +cc Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>

You are absolutely right, I agree on all points. I completely missed that
intel_gpu_top already shows power. At this point it only shows power for
integrated, we need to switch it from the rapl interface to igt_power
interface, igt_power supports both integrated and discrete (integrated
using rapl and discrete using hwmon).

I might resumbit this patch as a test, but tools wise I think the direction
should be to extend intel_gpu_top to support discrete.

Thanks.
--
Ashutosh