From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B7FC10EABE for ; Sat, 19 Feb 2022 00:33:22 +0000 (UTC) Date: Fri, 18 Feb 2022 16:23:48 -0800 Message-ID: <87iltb7lgr.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jasmine Newsome In-Reply-To: <20220219001013.3528897-2-jasmine.newsome@intel.com> References: <20220219001013.3528897-1-jasmine.newsome@intel.com> <20220219001013.3528897-2-jasmine.newsome@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload.c: Save more context info in spinner List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, 18 Feb 2022 16:10:12 -0800, Jasmine Newsome wrote: > > Save igt_spin_factory info in igt_spin. This will allow > for access to the actual context within the spinner. > Previously, only the context id was accessible. This > might help make spinner code cleaner. Since we are doing another rev. I'd suggest changing the title of this patch to something like "lib/igt_dummyload: Save spin->opts as part of the spinner". The patch itself is great!