From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5C52C89F07
 for <igt-dev@lists.freedesktop.org>; Mon, 27 Sep 2021 16:10:20 +0000 (UTC)
Date: Mon, 27 Sep 2021 09:09:56 -0700
Message-ID: <87ilymvw2z.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20210927112100.87984-1-zbigniew.kempczynski@intel.com>
References: <20210927112100.87984-1-zbigniew.kempczynski@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Remove
 duplicated assignment
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 27 Sep 2021 04:21:00 -0700, Zbigniew Kempczy=F1ski wrote:
>
> Due to some changes related in the alignment in the future remove
> unnecessary assignment.
>
> Signed-off-by: Zbigniew Kempczy=F1ski <zbigniew.kempczynski@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  lib/intel_batchbuffer.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index 399d0e990..e3e649ca3 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -2020,9 +2020,6 @@ __intel_bb_add_intel_buf(struct intel_bb *ibb, stru=
ct intel_buf *buf,
>				  buf->addr.offset, alignment, write);
>	buf->addr.offset =3D obj->offset;
>
> -	if (!ibb->enforce_relocs)
> -		obj->alignment =3D alignment;
> -

OK so you are saying that the assignment in intel_bb_add_object() is
already sufficient.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>	if (igt_list_empty(&buf->link)) {
>		igt_list_add_tail(&buf->link, &ibb->intel_bufs);
>		buf->ibb =3D ibb;
> --
> 2.26.0
>