Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v6 05/16] Add PXP attribute support in batchbuffer and buffer_ops libs
Date: Fri, 16 Jul 2021 13:12:10 -0700	[thread overview]
Message-ID: <87im1aqaqt.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210716092334.961262-6-alan.previn.teres.alexis@intel.com>

On Fri, 16 Jul 2021 02:23:23 -0700, Alan Previn wrote:
>
> Eventually when we get to testing PXP rendering capability,
> we shall reuse lib's rendercopy feature. Rendercopy libraries
> shall retrieve information about PXP-session-enablement and
> which buffers are protected from these new flags.

A couple of nits below otherwise this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> diff --git a/lib/intel_batchbuffer.h b/lib/intel_batchbuffer.h
> index bd417e99..1c5ce3fa 100644
> --- a/lib/intel_batchbuffer.h
> +++ b/lib/intel_batchbuffer.h
>
> +static inline uint32_t intel_bb_pxp_appid(struct intel_bb *ibb)
> +{
> +	igt_assert(ibb);

Not sure if we need these asserts in all these functions. Most similar
functions don't seem to have these but some do too so maybe ok.

> +	return ibb->pxp.appid;
> +}
> +
>  struct drm_i915_gem_exec_object2 *
>  intel_bb_add_object(struct intel_bb *ibb, uint32_t handle, uint64_t size,
>		    uint64_t offset, uint64_t alignment, bool write);
> @@ -687,3 +714,4 @@ typedef void (*igt_huc_copyfunc_t)(int fd,
>
>  igt_huc_copyfunc_t	igt_get_huc_copyfunc(int devid);
>  #endif
> +

Delete this empty line at the bottom.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-07-16 20:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  9:23 [igt-dev] [PATCH i-g-t v6 00/16] Introduce PXP Test Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 01/16] Add PXP UAPI support in i915_drm.h Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 02/16] Update IOCTL wrapper with DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 03/16] Add basic PXP testing of buffer and context alloc Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 04/16] Perform a regular 3d copy as a control checkpoint Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 05/16] Add PXP attribute support in batchbuffer and buffer_ops libs Alan Previn
2021-07-16 20:12   ` Dixit, Ashutosh [this message]
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 06/16] Add MI_SET_APPID instruction definition Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 07/16] Enable protected session cmd in gen12_render_copyfunc Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 08/16] Add subtest to copy raw source to protected dest Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 09/16] Add test where both src and dest are protected Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 10/16] Verify PXP teardown occurred through suspend-resume Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 11/16] Verify execbuf fails with stale PXP context after teardown Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 12/16] Verify execbuf fails with stale PXP buffer " Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 13/16] Verify execbuf ok with stale prot-buff and regular context Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 14/16] Ensure RESET_STATS reports invalidated protected context Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 15/16] Verify protected surfaces are dma buffer sharable Alan Previn
2021-07-16  9:23 ` [igt-dev] [PATCH i-g-t v6 16/16] tests/i915_pxp: CRC validation for display tests Alan Previn
2021-07-16 10:08 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Introduce PXP Test (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im1aqaqt.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=alan.previn.teres.alexis@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox