From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E78289F33 for ; Mon, 28 Sep 2020 20:53:42 +0000 (UTC) Date: Mon, 28 Sep 2020 13:53:35 -0700 Message-ID: <87imbx7hdc.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20200903110110.2403699-2-ayaz.siddiqui@intel.com> References: <20200903110110.2403699-1-ayaz.siddiqui@intel.com> <20200903110110.2403699-2-ayaz.siddiqui@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ayaz A Siddiqui Cc: igt-dev@lists.freedesktop.org List-ID: On Thu, 03 Sep 2020 04:01:09 -0700, Ayaz A Siddiqui wrote: > > DRM subsystem filter in intel_gpu_top was not working due to missing > PCI_SLOT_NAME property. Using the parent device in case of drm subsystem > leads to fix this issue. > > Signed-off-by: Ayaz A Siddiqui > --- > lib/igt_device_scan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c > index 345bae76d..3583c69c7 100644 > --- a/lib/igt_device_scan.c > +++ b/lib/igt_device_scan.c > @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card) > /* We take first one if more than one card matches filter */ > dev = igt_list_first_entry(&igt_devs.filtered, dev, link); > > - __copy_dev_to_card(dev, card); > + __copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card); Also I am wondering if this is required for only drm system then should this line be: __copy_dev_to_card(is_drm_subsystem(dev) ? dev->parent : dev, card) Also does lsgpu (the only other caller of igt_device_card_match()) work with this change? _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev