Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 4/8] pciids/i915: break TGL into GT1/2
Date: Mon, 31 Aug 2020 15:20:32 -0700	[thread overview]
Message-ID: <87imcyqwy7.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200831150951.357727-5-lionel.g.landwerlin@intel.com>

On Mon, 31 Aug 2020 08:09:47 -0700, Lionel Landwerlin wrote:
>
> Align with kernel commit:
> d452bd091e168f ("drm/i915: break TGL pci-ids in GT 1 & 2")

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>  lib/i915_pciids.h       | 14 ++++++++++----
>  lib/intel_device_info.c | 15 ++++++++++++---
>  2 files changed, 22 insertions(+), 7 deletions(-)
>
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 8e7ae30e..7eeecb07 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -594,19 +594,25 @@
>	INTEL_VGA_DEVICE(0x4E51, info)
>
>  /* TGL */
> -#define INTEL_TGL_12_IDS(info) \
> +#define INTEL_TGL_12_GT1_IDS(info) \
> +	INTEL_VGA_DEVICE(0x9A60, info), \
> +	INTEL_VGA_DEVICE(0x9A68, info), \
> +	INTEL_VGA_DEVICE(0x9A70, info)
> +
> +#define INTEL_TGL_12_GT2_IDS(info) \
>	INTEL_VGA_DEVICE(0x9A40, info), \
>	INTEL_VGA_DEVICE(0x9A49, info), \
>	INTEL_VGA_DEVICE(0x9A59, info), \
> -	INTEL_VGA_DEVICE(0x9A60, info), \
> -	INTEL_VGA_DEVICE(0x9A68, info), \
> -	INTEL_VGA_DEVICE(0x9A70, info), \
>	INTEL_VGA_DEVICE(0x9A78, info), \
>	INTEL_VGA_DEVICE(0x9AC0, info), \
>	INTEL_VGA_DEVICE(0x9AC9, info), \
>	INTEL_VGA_DEVICE(0x9AD9, info), \
>	INTEL_VGA_DEVICE(0x9AF8, info)
>
> +#define INTEL_TGL_12_IDS(info) \
> +	INTEL_TGL_12_GT1_IDS(info), \
> +	INTEL_TGL_12_GT2_IDS(info)
> +
>  /* RKL */
>  #define INTEL_RKL_IDS(info) \
>	INTEL_VGA_DEVICE(0x4C80, info), \
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index d5f70156..e1132d9c 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -315,10 +315,18 @@ static const struct intel_device_info intel_elkhartlake_info = {
>	.codename = "elkhartlake"
>  };
>
> -static const struct intel_device_info intel_tigerlake_info = {
> +static const struct intel_device_info intel_tigerlake_gt1_info = {
>	.gen = BIT(11),
>	.is_tigerlake = true,
> -	.codename = "tigerlake"
> +	.codename = "tigerlake",
> +	.gt = 1,
> +};
> +
> +static const struct intel_device_info intel_tigerlake_gt2_info = {
> +	.gen = BIT(11),
> +	.is_tigerlake = true,
> +	.codename = "tigerlake",
> +	.gt = 2,
>  };
>
>  static const struct intel_device_info intel_rocketlake_info = {
> @@ -416,7 +424,8 @@ static const struct pci_id_match intel_device_match[] = {
>
>	INTEL_EHL_IDS(&intel_elkhartlake_info),
>
> -	INTEL_TGL_12_IDS(&intel_tigerlake_info),
> +	INTEL_TGL_12_GT1_IDS(&intel_tigerlake_gt1_info),
> +	INTEL_TGL_12_GT2_IDS(&intel_tigerlake_gt2_info),
>	INTEL_RKL_IDS(&intel_rocketlake_info),
>
>	INTEL_DG1_IDS(&intel_dg1_info),
> --
> 2.28.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-08-31 22:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 15:09 [igt-dev] [PATCH i-g-t v2 0/8] lib/i915/perf: Add new platform metrics Lionel Landwerlin
2020-08-31 15:09 ` [igt-dev] [PATCH i-g-t v2 1/8] lib/i915_perf: drop dependency on libigt Lionel Landwerlin
2020-08-31 15:09 ` [igt-dev] [PATCH i-g-t v2 2/8] lib/i915/perf: fixup converter script Lionel Landwerlin
2020-08-31 15:09 ` [igt-dev] [PATCH i-g-t v2 3/8] lib/i915/perf: small ICL equation refactor Lionel Landwerlin
2020-08-31 15:09 ` [igt-dev] [PATCH i-g-t v2 4/8] pciids/i915: break TGL into GT1/2 Lionel Landwerlin
2020-08-31 22:20   ` Dixit, Ashutosh [this message]
2020-09-03 15:50   ` Umesh Nerlige Ramappa
2020-09-03 15:55     ` Lionel Landwerlin
2020-08-31 15:09 ` [igt-dev] [PATCH i-g-t v2 5/8] lib/i915/perf: break TGL metrics in 2 Lionel Landwerlin
2020-08-31 15:09 ` [igt-dev] [PATCH i-g-t v2 6/8] lib/i915/perf: add AsyncCompute metrics Lionel Landwerlin
2020-08-31 15:09 ` [igt-dev] [PATCH i-g-t v2 7/8] lib/i915/perf: Add Rocketlake metrics Lionel Landwerlin
2020-08-31 15:09 ` [igt-dev] [PATCH i-g-t v2 8/8] lib/i915/perf: Add DG1 metrics Lionel Landwerlin
2020-08-31 16:00 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/i915/perf: Add new platform metrics (rev2) Patchwork
2020-08-31 22:20 ` [igt-dev] [PATCH i-g-t v2 0/8] lib/i915/perf: Add new platform metrics Dixit, Ashutosh
2020-08-31 23:50 ` [igt-dev] ✓ Fi.CI.IGT: success for lib/i915/perf: Add new platform metrics (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imcyqwy7.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox