From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4FA2489E15 for ; Tue, 12 Mar 2019 13:42:07 +0000 (UTC) From: Jani Nikula In-Reply-To: <20190311132309.11061-1-daniel.t.mrzyglod@intel.com> References: <20190311132309.11061-1-daniel.t.mrzyglod@intel.com> Date: Tue, 12 Mar 2019 15:43:57 +0200 Message-ID: <87imwojjhe.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] lib: add pci helper functions to intel_chipset List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Mrzyglod , igt-dev@lists.freedesktop.org Cc: Mrzyglod@freedesktop.org List-ID: T24gTW9uLCAxMSBNYXIgMjAxOSwgRGFuaWVsIE1yenlnbG9kIDxkYW5pZWwudC5tcnp5Z2xvZEBp bnRlbC5jb20+IHdyb3RlOgo+IEZyb206ICJNcnp5Z2xvZCwgRGFuaWVsIFQiIDxkYW5pZWwudC5t cnp5Z2xvZEBpbnRlbC5jb20+Cj4KPiBUaGlzIHBhdGNoIGFkZCB0d28gaGVscGVyIGZ1bmN0aW9u czoKPiAgKiByZWFkaW5nIHJlZ2lzdGVyIGZyb20gUENJIGJhc2VkIG9uIG9wZW4gZmQKPiAgKiBn ZXR0aW5nIFBDSSBkb21haW4vYnVzL2Rldi9mdW5jIGJhc2VkIG9uIGZkCj4KPiBUaGUgcmVhc29u IHdoeSB3ZSBuZWVkIHRoaXMgZnVuY3Rpb24gaXMgdXAgdG8gc2NlbmFyaW8gd2hlbiB3ZSBoYXZl Cj4gbXVsdGlwbGUgUENJIGRldmljZXMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBNcnp5Z2xvZCwgRGFu aWVsIFQgPGRhbmllbC50Lm1yenlnbG9kQGludGVsLmNvbT4KPiAtLS0KPiAgbGliL2ludGVsX2No aXBzZXQuYyB8IDE3NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Kwo+ICBsaWIvaW50ZWxfY2hpcHNldC5oIHwgIDEzICsrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAx ODkgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2xpYi9pbnRlbF9jaGlwc2V0LmMgYi9s aWIvaW50ZWxfY2hpcHNldC5jCj4gaW5kZXggNDc0OGEzZmIuLjNkZDcyMmQ2IDEwMDY0NAo+IC0t LSBhL2xpYi9pbnRlbF9jaGlwc2V0LmMKPiArKysgYi9saWIvaW50ZWxfY2hpcHNldC5jCj4gQEAg LTM2LDYgKzM2LDcgQEAKPiAgI2luY2x1ZGUgPGZjbnRsLmg+Cj4gICNpbmNsdWRlIDxzeXMvc3Rh dC5oPgo+ICAjaW5jbHVkZSA8c3lzL21tYW4uaD4KPiArI2luY2x1ZGUgPGxpbnV4L2xpbWl0cy5o Pgo+ICAjaW5jbHVkZSAiaTkxNV9kcm0uaCIKPiAgCj4gICNpbmNsdWRlICJkcm10ZXN0LmgiCj4g QEAgLTE3OCwzICsxNzksMTc4IEBAIGludGVsX2NoZWNrX3BjaCh2b2lkKQo+ICAJCXJldHVybjsK PiAgCX0KPiAgfQo+ICsKPiArLyoqCj4gKyAqIHBhcnNlX3BjaV9hZGRyZXNzX3N0cmluZzoKPiAr ICogQHBjaV9hZGRyZXNzOiBQQ0kgc3RyaW5nIGluIGZvcm0gMDAwMDowMDowMC4wCj4gKyAqIEBk ZXZfYWRkcjogc3RydWN0dXJlIHRvIGJlIGZpbGxlZCBieSB0aGlzIHBhcnNpbmcgZnVuY3Rpb24K PiArICoKPiArICogVGhpcyBmdW5jdGlvbiBmaWxsIGZkX3BjaV9hZGRyZXNzIHN0cnVjdHVyZSB3 aXRoIGRhdGEgYWJvdXQgcGNpOiBkb21haW4sIGJ1cwo+ICsgKiBkZXZpY2UsIGZ1bmN0aW9uCj4g KyAqIFJldHVybjoKPiArICogTyBvciAtRUlOVkFMCj4gKyAqLwo+ICtzdGF0aWMgaW50IHBhcnNl X3BjaV9hZGRyZXNzX3N0cmluZyhjaGFyICpwY2lfYWRkcmVzcywKPiArCQkJCSAgICBzdHJ1Y3Qg ZmRfcGNpX2FkZHJlc3MgKmRldl9hZGRyKQo+ICt7Cj4gKwl1bnNpZ25lZCBsb25nIHZhbDsKPiAr CWNoYXIgKnBjaDsKPiArCWludCBpID0gMDsKPiArCj4gKwlpZiAoc3RybGVuKHBjaV9hZGRyZXNz KSAhPSAxMikKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gKwkvKiBwYXJzZSBQQ0kgYWRkcmVz cyAgc3RyaW5nIGZvciBkb21haW4gKi8KPiArCXBjaCA9IHN0cnRvayhwY2lfYWRkcmVzcywgIjou Iik7Cj4gKwllcnJubyA9IDA7Cj4gKwl2YWwgPSBzdHJ0b3VsKHBjaCwgTlVMTCwgMTYpOwo+ICsJ aWYgKGVycm5vICE9IDAgfHwgdmFsID4gVUlOVDE2X01BWCkKPiArCQlyZXR1cm4gLUVJTlZBTDsK PiArCWRldl9hZGRyLT5kb21haW4gPSB2YWw7Cj4gKwo+ICsJLyogcGFyc2UgIFBDSSBhZGRyZXNz IGZvcjogQlVTIERFVklDRSBGVU5DVElPTiAqLwo+ICsJZm9yIChpID0gMDsgaSA8IDM7IGkrKykg ewo+ICsJCXBjaCA9IHN0cnRvayhOVUxMLCAiOi4iKTsKPiArCQllcnJubyA9IDA7Cj4gKwkJdmFs ID0gc3RydG91bChwY2gsIE5VTEwsIDE2KTsKPiArCQlpZiAoZXJybm8gIT0gMCB8fCB2YWwgPiBV SU5UOF9NQVgpCj4gKwkJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCQlzd2l0Y2ggKGkpIHsKPiAr CQljYXNlIDA6Cj4gKwkJCWRldl9hZGRyLT5idXMgPSB2YWw7Cj4gKwkJCWJyZWFrOwo+ICsJCWNh c2UgMToKPiArCQkJZGV2X2FkZHItPmRldiA9IHZhbDsKPiArCQkJYnJlYWs7Cj4gKwkJY2FzZSAy Ogo+ICsJCQlkZXZfYWRkci0+ZnVuYyA9IHZhbDsKPiArCQkJYnJlYWs7Cj4gKwkJZGVmYXVsdDoK PiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJYnJlYWs7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCXBj aCA9IHN0cnRvayhOVUxMLCAiOi4iKTsKPiArCWlmIChwY2gpCj4gKwkJcmV0dXJuIC1FSU5WQUw7 Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KCnN0YXRpYyBpbnQgcGFyc2VfcGNpX2FkZHJlc3Nfc3Ry aW5nKGNvbnN0IGNoYXIgKnBjaV9hZGRyZXNzLAoJCQkJICAgIHN0cnVjdCBmZF9wY2lfYWRkcmVz cyAqZGV2X2FkZHIpCnsKICAgICAgICBpbnQgcmV0OwoJdW5zaWduZWQgaW50IGRvbWFpbiwgYnVz LCBkZXYsIGZ1bmM7CgoJcmV0ID0gc3NjYW5mKHBjaV9hZGRyZXNzLCAiJTR4OiUyeDolMnguJTF4 IiwgJmRvbWFpbiwgJmJ1cywgJmRldiwgJmZ1bmMpOwoJaWYgKHJldCAhPSA0KQogICAgICAgIAly ZXR1cm4gLUVJTlZBTDsKCglkZXZfYWRkci0+ZG9tYWluID0gZG9tYWluOwoJZGV2X2FkZHItPmJ1 cyA9IGJ1czsKICAgICAgICBkZXZfYWRkci0+ZGV2ID0gZGV2OwogICAgICAgIGRldl9hZGRyLT5m dW5jID0gZnVuYzsKCglyZXR1cm4gMDsKfQoKQlIsCkphbmkuCgoKPiArCj4gKy8qKgo+ICsgKiBw YXJzZV9wY2lfZmlsZXBhdGhfc3RyaW5nOgo+ICsgKiBAZmlsZXBhdGg6IHN0cmluZyBpbiBmb3Jt IC4uLy4uL2RldmljZXMvcGNpMDAwMDowMC8wMDAwOjAwOjAwLjAvZHJtL2NhcmQwCj4gKyAqIEBk ZXZfYWRkcjogc3RydWN0dXJlIHRvIGJlIGZpbGxlZCBieSB0aGlzIHBhcnNpbmcgZnVuY3Rpb24K PiArICoKPiArICogVGhpcyBmdW5jdGlvbiBwYXJzZSBmaWxlcGF0aCBzdHJpbmcgdG8gUENJIGFk ZHJlc3Mgc3RyaW5nIDAwMDA6MDA6MDAuMCBmb3JtLgo+ICsgKiBhbmQgZmlsbCBkZXZfYWRkci4K PiArICogUmV0dXJuOgo+ICsgKiBPIG9yIC1FSU5WQUwKPiArICovCj4gK3N0YXRpYyBpbnQKPiAr cGFyc2VfcGNpX2ZpbGVwYXRoX3N0cmluZyhjaGFyICpmaWxlcGF0aCwgc3RydWN0IGZkX3BjaV9h ZGRyZXNzICpkZXZfYWRkcikKPiArewo+ICsJY2hhciAqcGNoID0gc3Ryc3RyKGZpbGVwYXRoLCAi cGNpIik7Cj4gKwljaGFyICpiZWdpbiA9IE5VTEw7Cj4gKwljaGFyICplbmQgPSBOVUxMOwo+ICsK PiArCWlmIChwY2gpIHsKPiArCQlwY2ggPSBzdHJzdHIocGNoLCAiLyIpOwo+ICsJCXBjaCsrOwo+ ICsJCWJlZ2luID0gcGNoOwo+ICsJCWVuZCA9IHN0cnN0cihwY2gsICIvIik7Cj4gKwkJKmVuZCA9 ICdcMCc7Cj4gKwkJfSBlbHNlIHsKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJfQo+ICsJaWYg KHN0cmxlbihiZWdpbikgIT0gMTIpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwlpZiAocGFyc2Vf cGNpX2FkZHJlc3Nfc3RyaW5nKGJlZ2luLCBkZXZfYWRkcikgPCAwKQo+ICsJCXJldHVybiAtRUlO VkFMOwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBnZXRfcGNpX2FkZHJlc3Nf c3BhY2U6Cj4gKyAqIEBmZDogZmlsZSBkZXNjcmlwdG9yIG9mIG9wZW5lZCBkZXZpY2UKPiArICog QGRldl9hZGRyOiBzdHJ1Y3R1cmUgd2l0aCBwY2lfYWRkcmVzcyB0byBiZSBmaWxsZWQgYnkgdGhp cyBwYXJzaW5nIGZ1bmN0aW9uCj4gKyAqCj4gKyAqIFRoaXMgZnVuY3Rpb24gZmlsbCBkZXZfYWRk ciBmcm9tIHJlYWRpbmcgZnN0YXRzIGZyb20gb3BlbmVkIGRldmljZS4KPiArICogZnJvbSBpdC4K PiArICogUmV0dXJuOgo+ICsgKiBPIG9yIC1FSU5WQUwKPiArICovCj4gK2ludCBpbnRlbF9nZXRf cGNpX2FkZHJlc3Nfc3BhY2UoaW50IGZkLCBzdHJ1Y3QgZmRfcGNpX2FkZHJlc3MgKmRldl9hZGRy KQo+ICt7Cj4gKwlzdHJ1Y3Qgc3RhdCBzYjsKPiArCWNoYXIgZmlsZXBhdGhbUEFUSF9NQVhdOwo+ ICsJY2hhciBmZHBbUEFUSF9NQVhdOwo+ICsJaW50IHJldCA9IC0xOwo+ICsKPiArCWlmIChmc3Rh dChmZCwgJnNiKSA9PSAtMSkgewo+ICsJCXBlcnJvcigic3RhdCIpOwo+ICsJCXJldHVybiAtRUlO VkFMOwo+ICsJfQo+ICsKPiArCXNwcmludGYoZmRwLCAiL3N5cy9kZXYvY2hhci8lZDolZCIsICBt YWpvcihzYi5zdF9yZGV2KSwKPiArCQltaW5vcihzYi5zdF9yZGV2KSk7Cj4gKwlyZWFkbGluayhm ZHAsIGZpbGVwYXRoLCBQQVRIX01BWCk7Cj4gKwo+ICsJcmV0ID0gcGFyc2VfcGNpX2ZpbGVwYXRo X3N0cmluZyhmaWxlcGF0aCwgZGV2X2FkZHIpOwo+ICsJaWYgKHJldCA8IDApCj4gKwkJcmV0dXJu IC1FSU5WQUw7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBwY2lfcmVh ZF9yZWdpc3Rlcl91MzI6Cj4gKyAqIEBmZDogZmlsZSBkZXNjcmlwdG9yIG9mIG9wZW5lZCBkZXZp Y2UKPiArICogQHJlZ19uYW1lOiBvZmZzZXQgaW4gbW1pbyBzcGFjZQo+ICsgKgo+ICsgKiBUaGlz IGZ1bmN0aW9uIHJlYWQgVUlOVDMyIGZyb20gcGNpLgo+ICsgKiBSZXR1cm46Cj4gKyAqIFJlZ2lz dGVyIHZhbHVlIG9yIGlndF9mYWlsCj4gKyAqLwo+ICt1aW50MzJfdCBpbnRlbF9wY2lfcmVhZF9y ZWdpc3Rlcl91MzIoaW50IGZkLCB1aW50MzJfdCByZWdfbmFtZSkKPiArewo+ICsJdWludDMyX3Qg cmVnX3ZhbCA9IDA7Cj4gKwlpbnQgZXJyb3IgPSAtMTsKPiArCWludCBtbWlvX2JhciwgbW1pb19z aXplOwo+ICsJc3RydWN0IHBjaV9kZXZpY2UgKmRldjsKPiArCXN0cnVjdCBmZF9wY2lfYWRkcmVz cyBkZXZfYWRkcjsKPiArCXZvaWQgKmlndF9tbWlvOwo+ICsKPiArCWludGVsX2dldF9wY2lfYWRk cmVzc19zcGFjZShmZCwgJmRldl9hZGRyKTsKPiArCXBjaV9zeXN0ZW1faW5pdCgpOwo+ICsJZGV2 ID0gcGNpX2RldmljZV9maW5kX2J5X3Nsb3QoKHVpbnQzMl90KWRldl9hZGRyLmRvbWFpbiwKPiAr CQkJCSAgICAgICh1aW50MzJfdClkZXZfYWRkci5idXMsCj4gKwkJCQkgICAgICAodWludDMyX3Qp ZGV2X2FkZHIuZGV2LAo+ICsJCQkJICAgICAgKHVpbnQzMl90KWRldl9hZGRyLmZ1bmMpOwo+ICsK PiArCWVycm9yID0gcGNpX2RldmljZV9wcm9iZShkZXYpOwo+ICsJaWd0X2ZhaWxfb25fZihlcnJv ciAhPSAwLAo+ICsJCSAgICAgICJDb3VsZG4ndCBwcm9iZSBncmFwaGljcyBjYXJkXG4iKTsKPiAr Cj4gKwltbWlvX2JhciA9IDA7Cj4gKwltbWlvX3NpemUgPSAyICogMTAyNCAqIDEwMjQ7Cj4gKwo+ ICsJZXJyb3IgPSBwY2lfZGV2aWNlX21hcF9yYW5nZShkZXYsCj4gKwkJCQkgICAgIGRldi0+cmVn aW9uc1ttbWlvX2Jhcl0uYmFzZV9hZGRyLAo+ICsJCQkJICAgICBtbWlvX3NpemUsCj4gKwkJCQkg ICAgIFBDSV9ERVZfTUFQX0ZMQUdfV1JJVEFCTEUsCj4gKwkJCQkgICAgICZpZ3RfbW1pbyk7Cj4g KwlpZ3RfZmFpbF9vbl9mKGVycm9yICE9IDAsCj4gKwkJICAgICAgIkNvdWxkbid0IG1hcCBNTUlP IHJlZ2lvblxuIik7Cj4gKwo+ICsJcmVnX3ZhbCA9ICoodm9sYXRpbGUgdWludDMyX3QgKikoKHZv bGF0aWxlIGNoYXIgKilpZ3RfbW1pbyArIHJlZ19uYW1lKTsKPiArCj4gKwllcnJvciA9IHBjaV9k ZXZpY2VfdW5tYXBfcmFuZ2UoZGV2LCBpZ3RfbW1pbywKPiArCQkJCSAgICAgICBtbWlvX3NpemUp Owo+ICsJaWd0X2ZhaWxfb25fZihlcnJvciAhPSAwLAo+ICsJCSAgICAgICJDb3VsZG4ndCB1bm1h cCBNTUlPIHJlZ2lvblxuIik7Cj4gKwo+ICsJcmV0dXJuIHJlZ192YWw7Cj4gK30KPiBkaWZmIC0t Z2l0IGEvbGliL2ludGVsX2NoaXBzZXQuaCBiL2xpYi9pbnRlbF9jaGlwc2V0LmgKPiBpbmRleCA0 MDE3MGI3Yi4uOTZhNjE4ZWIgMTAwNjQ0Cj4gLS0tIGEvbGliL2ludGVsX2NoaXBzZXQuaAo+ICsr KyBiL2xpYi9pbnRlbF9jaGlwc2V0LmgKPiBAQCAtNzMsNiArNzMsMTkgQEAgc3RydWN0IGludGVs X2RldmljZV9pbmZvIHsKPiAgCj4gIGNvbnN0IHN0cnVjdCBpbnRlbF9kZXZpY2VfaW5mbyAqaW50 ZWxfZ2V0X2RldmljZV9pbmZvKHVpbnQxNl90IGRldmlkKSBfX2F0dHJpYnV0ZV9fKChwdXJlKSk7 Cj4gIAo+ICtzdHJ1Y3QgZmRfcGNpX2FkZHJlc3Mgewo+ICsJLyoqCj4gKwkgKiBQQ0kgQWRkcmVz cwo+ICsJICovCj4gKwl1aW50MTZfdAlkb21haW47Cj4gKwl1aW50OF90CQlidXM7Cj4gKwl1aW50 OF90CQlkZXY7Cj4gKwl1aW50OF90CQlmdW5jOwo+ICt9Owo+ICsKPiArdWludDMyX3QgaW50ZWxf cGNpX3JlYWRfcmVnaXN0ZXJfdTMyKGludCBmZCwgdWludDMyX3QgcmVnX25hbWUpOwo+ICtpbnQg aW50ZWxfZ2V0X3BjaV9hZGRyZXNzX3NwYWNlKGludCBmZCwgc3RydWN0IGZkX3BjaV9hZGRyZXNz ICpkZXZfYWRkcik7Cj4gKwo+ICB1bnNpZ25lZCBpbnRlbF9nZW4odWludDE2X3QgZGV2aWQpIF9f YXR0cmlidXRlX18oKHB1cmUpKTsKPiAgdW5zaWduZWQgaW50ZWxfZ3QodWludDE2X3QgZGV2aWQp IF9fYXR0cmlidXRlX18oKHB1cmUpKTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3Vy Y2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRl dg==