From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 135D110F626
 for <igt-dev@lists.freedesktop.org>; Wed, 27 Apr 2022 16:04:05 +0000 (UTC)
Date: Wed, 27 Apr 2022 08:56:49 -0700
Message-ID: <87k0ba5xku.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
 igt-dev@lists.freedesktop.org,
 Priyanka Dandamudi <priyanka.dandamudi@intel.com>,
 Andi Shyti <andi.shyti@intel.com>,
 Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
 Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>,
 Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
 Ashutosh Dixit <ashutosh.dixit@intel.com>
In-Reply-To: <YmkrTvxDCv840AT2@kamilkon-DESK1>
References: <20220426150415.519750-1-priyanka.dandamudi@intel.com>
 <YmkrTvxDCv840AT2@kamilkon-DESK1>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_sysfs: Add helpers to iterate
 over GTs
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Wed, 27 Apr 2022 04:38:54 -0700, Kamil Konieczny wrote:
>
> > +/**
> > + * igt_sysfs_gt_open:
> > + * @device: fd of the device
> > + * @gt: gt number
> > + *
> > + * This opens the sysfs gt directory corresponding to device and gt for use
> > + * with igt_sysfs_set() and igt_sysfs_get().
> > + *
> > + * Returns:
> > + * The directory fd, or -1 on failure.
> > + */
> > +int igt_sysfs_gt_open(int device, int gt)
> > +{
> > +	char path[96];
> > +
> > +	if (igt_debug_on(!igt_sysfs_gt_path(device, gt, path, sizeof(path))))
> ----------- ^
> imho here we should not use igt_debug_on because we use this
> function in iterator macro for_each_sysfs_gt_dirfd and the end
> condition is hitting end of available GTs and returning -1.

Hi Kamil,

You are right, I removed other igt_debug_on's and merged it but missed this
one. Somebody will need to send a patch for this. Sorry about that.

Thanks.
--
Ashutosh