From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E9EC97360B
 for <igt-dev@lists.freedesktop.org>; Thu,  4 Nov 2021 17:36:25 +0000 (UTC)
Date: Thu, 04 Nov 2021 10:36:09 -0700
Message-ID: <87k0hnakmu.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <75ba03a7-109d-7495-618d-c370832f8e15@intel.com>
References: <cover.1635895537.git.ashutosh.dixit@intel.com>
 <80835b2bb39219876667cc426266b7e829a07bfb.1635895537.git.ashutosh.dixit@intel.com>
 <75ba03a7-109d-7495-618d-c370832f8e15@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t 2/4] lib/i915: Return actual submission
 method from gem_submission_method
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: John Harrison <john.c.harrison@intel.com>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

On Wed, 03 Nov 2021 11:22:25 -0700, John Harrison wrote:
>
> > diff --git a/lib/i915/gem_submission.h b/lib/i915/gem_submission.h
> > index 55bcfc09965..1c82e3c5ede 100644
> > --- a/lib/i915/gem_submission.h
> > +++ b/lib/i915/gem_submission.h
> > @@ -28,8 +28,9 @@
> >     #include "intel_ctx.h"
> >   -#define GEM_SUBMISSION_EXECLISTS	(1 << 1)
> > -#define GEM_SUBMISSION_GUC		(1 << 2)
> > +#define GEM_SUBMISSION_LEGACY_RING_BUF	1
> As per comment above, I would just name this GEM_SUBMISSION_RINGBUF.
>
> With that changed:
> Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

Thanks, made the change and merged now.