From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A533C52D70 for ; Tue, 6 Aug 2024 19:48:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B22D510E3F2; Tue, 6 Aug 2024 19:48:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LFV4Kcmo"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE9B510E3F2 for ; Tue, 6 Aug 2024 19:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722973709; x=1754509709; h=date:message-id:from:to:subject:in-reply-to:references: mime-version; bh=8rYuNPWoECxruIaNLGFoaUCbk32JwKq7KbzhaotVvBQ=; b=LFV4KcmonVR5j/qQ2o1fwibrJkLKAQA6Wf5WtW8gUdmVnIuavayTw7+/ tkhMNWJdenW/aIOwgVk0vvCWDKcjTNm41i3LUUeoBAjcgZCkXzALX9pFT tZLwfE7NFidCLzmqTUMFRAYP3eGZdXSm3epGRQ3f711O3FhcOnou8ofdk dhbCuUaN/CrnoEIzjdAvN3QoFbvXgeLZj6w1D7gV+LE4a2kTdJXBgwSou wh0xiqkHNc5E1xQQwy5xzZQOkRWqCp8jrE5kGGI6t0zUI6whPj6b6mT/m ppbbJAuejExcUxcCCU7ESWJCStXPvXr3SWG1YJd+owM5XZJ7g0WC9eeqY w==; X-CSE-ConnectionGUID: nzZi9ApAQv2ntQb/KuIKcg== X-CSE-MsgGUID: qjV2DCnORMmKCariC0eWOQ== X-IronPort-AV: E=McAfee;i="6700,10204,11156"; a="20589131" X-IronPort-AV: E=Sophos;i="6.09,268,1716274800"; d="scan'208";a="20589131" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2024 12:48:28 -0700 X-CSE-ConnectionGUID: jOXDfd3FRJqFPieLdeG3SA== X-CSE-MsgGUID: TGWq1WU6RkOBWvVXm3qQsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,268,1716274800"; d="scan'208";a="87553628" Received: from jnmcinx-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.48.241]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2024 12:48:28 -0700 Date: Tue, 06 Aug 2024 12:48:25 -0700 Message-ID: <87le19a0vq.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , Peter Senna Tschudin , "igt-dev@lists.freedesktop.org" Subject: Re: [PATCH i-g-t v4] lib/xe/xe_query: Do not require QUERY_OA_UNITS for all Xe tests In-Reply-To: <20240731152436.o2r6avdnazrdk26l@kamilkon-DESK.igk.intel.com> References: <78c5f531-f482-49c7-8290-38710698e4a7@linux.intel.com> <355010f7-e6f4-4d01-a8dd-3be387b57dcf@linux.intel.com> <20240731152436.o2r6avdnazrdk26l@kamilkon-DESK.igk.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 31 Jul 2024 08:24:36 -0700, Kamil Konieczny wrote: > > Hi Peter, > On 2024-07-31 at 13:17:54 +0200, Peter Senna Tschudin wrote: > > The code currently requires the driver to support DRM_XE_DEVICE_QUERY_OA_UNITS > > to run all tests while the only test that needs it is xe_oa. Removes the > > requirement so that all other Xe tests can run when this single requirement is > > not met. > > > > I found it when trying to run IGT Xe tests on a recent kernel > > 6.9.9-200.fc40.x86_64 from Fedora 40. > > Looks much better, I spotted few nits, see below. Some people were running into this issue, so I just added my R-b and merged this upstream (without waiting for Kamil's ack/R-b). Thanks for the patch and the reviews. Ashutosh