From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 1/2] i915/gem_tiled_pread_*: Add check for FENCE based tiling support
Date: Mon, 03 Feb 2020 19:35:10 -0800 [thread overview]
Message-ID: <87lfpj3tzl.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200203072057.25593-2-ayaz.siddiqui@intel.com>
On Sun, 02 Feb 2020 23:20:56 -0800, Ayaz A Siddiqui wrote:
>
> These tests are verifying integrity of the tiled data read and write operation
> on platforms which supports FENCE based tiling.
>
> A check has been added to skip these tests if FENCES are not available
> in platform.
> Tests updated in this patch :
> 1. gem_tiled_pread_basic
> 2. gem_tiled_pread_pwrite
>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
After Chris' comments on v1:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
> tests/i915/gem_tiled_pread_basic.c | 2 +-
> tests/i915/gem_tiled_pread_pwrite.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_tiled_pread_basic.c b/tests/i915/gem_tiled_pread_basic.c
> index 1ac9eccd..7cb64410 100644
> --- a/tests/i915/gem_tiled_pread_basic.c
> +++ b/tests/i915/gem_tiled_pread_basic.c
> @@ -124,7 +124,7 @@ igt_simple_main
> uint32_t devid;
>
> fd = drm_open_driver(DRIVER_INTEL);
> -
> + igt_require(gem_available_fences(fd) > 0);
> handle = create_bo(fd);
> igt_require(gem_get_tiling(fd, handle, &tiling, &swizzle));
>
> diff --git a/tests/i915/gem_tiled_pread_pwrite.c b/tests/i915/gem_tiled_pread_pwrite.c
> index 0988a4e8..0bbb3a20 100644
> --- a/tests/i915/gem_tiled_pread_pwrite.c
> +++ b/tests/i915/gem_tiled_pread_pwrite.c
> @@ -113,6 +113,7 @@ igt_simple_main
> int fd;
>
> fd = drm_open_driver(DRIVER_INTEL);
> + igt_require(gem_available_fences(fd) > 0);
> count = SLOW_QUICK(intel_get_total_ram_mb() * 9 / 10, 8) ;
>
> for (int i = 0; i < count/2; i++) {
> --
> 2.24.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-04 3:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 7:20 [igt-dev] [PATCH i-g-t v2 0/2] Add check for FENCE based tiling support Ayaz A Siddiqui
2020-02-03 7:20 ` [igt-dev] [PATCH i-g-t v2 1/2] i915/gem_tiled_pread_*: " Ayaz A Siddiqui
2020-02-04 3:35 ` Dixit, Ashutosh [this message]
2020-02-03 7:20 ` [igt-dev] [PATCH i-g-t v2 2/2] i915/gem_render_tiled_blits: Add check for hardware based FENCE support Ayaz A Siddiqui
2020-02-03 8:37 ` [igt-dev] ✓ Fi.CI.BAT: success for Add check for FENCE based tiling support (rev2) Patchwork
2020-02-05 14:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfpj3tzl.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=ayaz.siddiqui@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox