From: Mika Kuoppala via igt-dev <igt-dev@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_mmap_gtt: Impose a timeout for "hang"
Date: Tue, 12 Feb 2019 12:56:13 +0200 [thread overview]
Message-ID: <87lg2l1diq.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190212101601.25562-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Only wait a maximum of 2 more seconds for the hang children to complete,
> to catch deadlocks in a timely fashion.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> tests/i915/gem_mmap_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index f9d811ad6..f6fbbe193 100644
> --- a/tests/i915/gem_mmap_gtt.c
> +++ b/tests/i915/gem_mmap_gtt.c
> @@ -450,7 +450,7 @@ test_hang(int fd)
> igt_info("%lu resets\n", count);
>
> control->done = true;
> - igt_waitchildren();
> + igt_waitchildren_timeout(2, NULL);
Seems that no-one is using the reason argument. You could have
been the first ever!
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> igt_assert(!control->error);
> munmap(control, 4096);
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-12 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 10:16 [igt-dev] [PATCH i-g-t] i915/gem_mmap_gtt: Impose a timeout for "hang" Chris Wilson
2019-02-12 10:49 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-12 10:56 ` Mika Kuoppala via igt-dev [this message]
2019-02-12 10:58 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Chris Wilson
2019-02-12 12:44 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg2l1diq.fsf@gaia.fi.intel.com \
--to=igt-dev@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox