From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02468CD342F for ; Fri, 8 May 2026 20:56:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 678BE10E341; Fri, 8 May 2026 20:56:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="EnL6Cgej"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB7C810E341 for ; Fri, 8 May 2026 20:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778273789; x=1809809789; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=cj2WhtPG6NSfO3bcuJZ64CxfUFx9J2TbgLe6XsCACxI=; b=EnL6CgejFwWdqlVQW3BLhQsX2erekmUbfCmOf9prONiaMBxEOn9oZ/3d duJNgnDN1Lae2lhVia73JNw1FAmPs29J+q/UeiCPtgfNdBbgRikt0VADU OLkNExEt1DxAdQ1i4uSe7myy2ChefsTgwfYx0c4ktSB8gDcAYOv+ThL+E L4MtE44xndINDM4RM4ELzV+Uo5CFnkkljFaSoSpTwP1QT3/tdDJzqiuUl CvaABPCc//wfZnyeo5D1Je8xW+dwQX4MRjqRx0L2gImpQ/ot1VJJnkSP/ Gb+3bNm2sYA95onIkrKZYPU/CqyaBA2N0Tfy6WE2kLmNrLOCju8c4xLQy w==; X-CSE-ConnectionGUID: 6u45gM7tQ0SEkirDNBE3xw== X-CSE-MsgGUID: QFi84OQ4Q42ASATjVL4EFw== X-IronPort-AV: E=McAfee;i="6800,10657,11780"; a="79293744" X-IronPort-AV: E=Sophos;i="6.23,224,1770624000"; d="scan'208";a="79293744" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 13:56:28 -0700 X-CSE-ConnectionGUID: LPf8oiLdQH+wZBzKkgYPeQ== X-CSE-MsgGUID: B2aND07CSO2RZ3TNl10W6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,224,1770624000"; d="scan'208";a="230469738" Received: from cbrown-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.134.206]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 13:56:28 -0700 Date: Fri, 08 May 2026 13:56:27 -0700 Message-ID: <87mry97h8k.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: Subject: Re: [PATCH v7 2/2] tests/intel/xe_oa: Wa_14026633728 In-Reply-To: <20260508021329.876072-3-shekhar.chauhan@intel.com> References: <20260508021329.876072-1-shekhar.chauhan@intel.com> <20260508021329.876072-3-shekhar.chauhan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Thu, 07 May 2026 19:13:29 -0700, Shekhar Chauhan wrote: > > For MERTOA in CRI, oa buffer can be in device memory. Because of slower > device mem access, OA exponent values lower than 8 can result in buffer > overflows. Bump the OA exponent value. > > Signed-off-by: Shekhar Chauhan > --- > tests/intel/xe_oa.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 988c46df6..2f73b5210 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -24,6 +24,7 @@ > #include "igt_device.h" > #include "igt_syncobj.h" > #include "igt_sysfs.h" > +#include "intel_wa.h" > #include "xe/xe_ioctl.h" > #include "xe/xe_query.h" > #include "xe/xe_oa.h" > @@ -2671,6 +2672,18 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > int len, check_idx; > u32 oa_status; > > + /* > + * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory. > + * Because of slower device mem access, OA exponent values lower than 8 > + * can result in buffer overflows. Also, update the value of oa_exponent > + * in properties[]. This last part in the comment, "Also, update the value of oa_exponent in properties[]" is obvious from reading the code. It should not be documented in comments. Anyway I have fixed this comment up this time and merged this series. Thanks. > + */ > + if (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && > + igt_has_intel_wa(drm_fd, "14026633728")) { > + oa_exponent = max(oa_exponent, 8); > + properties[9] = oa_exponent; > + } > + > igt_assert(buf); > > igt_debug("Ready to read about %u bytes\n", buf_size); > -- > 2.53.0 >