From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DEA0FED3FA for ; Fri, 24 Apr 2026 19:34:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 89BA010E3EF; Fri, 24 Apr 2026 19:34:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PMV4CBxb"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id CAEF010E041 for ; Fri, 24 Apr 2026 19:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777059262; x=1808595262; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=oT4pEU/KbAONIXyRXx5hLOBmCjNdgxiOhtYJZc9EU28=; b=PMV4CBxbhnmnH2LcMZccRBn/6GXaUYidwTuVwX+B3eGyJACtbE/58wFw hiR3h5KJ+9FBwf/lswhmqLmrR4bX6Dx5d8F0WLKGMAjyxH6QdzLwoI3j8 kOMB3Ab4lvOb4cv036EYifDINOHq2scZ5lEK30XKG+K5kXtvta+WRvOjr 8jz32WX7wJiwybdlKZx/KHd5gfaCGdi4H9FOsBSQVh5Ij/XxliWikraFQ vJywXrRYQtOehKfI2iD8/xQKeew4XISo8ZNJzOwFKBqF3BQyRH4+qPQUf zit+/6GTvEKNWA1aLEYYaf4T3ipNhcP2kKiwQrti3x6R93F2EvjErDQCt w==; X-CSE-ConnectionGUID: WcZCcXnhRuuN1DkY+16wuA== X-CSE-MsgGUID: gKVuki6sQNeGzB+mL03/eQ== X-IronPort-AV: E=McAfee;i="6800,10657,11766"; a="89428542" X-IronPort-AV: E=Sophos;i="6.23,197,1770624000"; d="scan'208";a="89428542" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2026 12:34:22 -0700 X-CSE-ConnectionGUID: Zw+3bmeOQOq+nSd1E2OmuQ== X-CSE-MsgGUID: 0NbIS6kfRP20R1cSB4y87g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,197,1770624000"; d="scan'208";a="232931842" Received: from thtran-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.33.103]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2026 12:34:21 -0700 Date: Fri, 24 Apr 2026 12:34:20 -0700 Message-ID: <87mrystao3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: Subject: Re: [PATCH] drm/xe/oa: Wa_14026633728 In-Reply-To: <20260424081354.3033523-1-shekhar.chauhan@intel.com> References: <20260424081354.3033523-1-shekhar.chauhan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 24 Apr 2026 01:13:54 -0700, Shekhar Chauhan wrote: > Hi Shekhar, The patch title prefix "drm/xe/oa: " is incorrect. Please use the same prefix as in previous commits. > For MERT_OA in CRI, the OA_Buffer is in device memory. The minimum > exponent needed for it is 8. Bump it up. For MERTOA in CRI, oa buffer can be in device memory. Because of slower device mem access, OA exponent values lower than 8 can result in buffer overflows. Bump the OA exponent value. > > Signed-off-by: Shekhar Chauhan > --- > tests/intel/xe_oa.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 988c46df6..7bd9d17c4 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -2645,6 +2645,12 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > { > /* ~20 micro second period */ > int oa_exponent = max_oa_exponent_for_period_lte(20000); > + > + /* Wa_14026633728: MERTOA buffer on CRI is in device memory, > + * minimum exponent to avoid overflow is 8 */ /* * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory. * Because of slower device mem access, OA exponent values lower than 8 can * result in buffer overflows. */ > + if (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && IS_CRESCENTISLAND(devid)) > + oa_exponent = max(oa_exponent, 8); > + The actual code is good!!! > struct intel_xe_perf_metric_set *test_set = oa_unit_metric_set(oau); > uint64_t fmt = test_set->perf_oa_format; > size_t report_size = get_oa_format(fmt).size; > -- > 2.53.0 > Thanks. -- Ashutosh