From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 362DAD778AE for ; Fri, 23 Jan 2026 19:25:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD2DA10EBC1; Fri, 23 Jan 2026 19:25:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HRLxwBSx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD6C710EBC1 for ; Fri, 23 Jan 2026 19:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769196332; x=1800732332; h=date:message-id:from:to:subject:in-reply-to:references: mime-version; bh=7/drRfWltq6BWfZ0WyuOt4iS7RsI+wOPd2yd2lvxIfQ=; b=HRLxwBSxPMfC9LjZDT93CKsioI1Y5QclBYGH+5S6D/j8Nndzx6l1sSoO KkM3D1adzrgtik8daGExnqLRZ3NFUVuVOEgerM8Dnzyr3aqf48OnTdaHT ASEPEcpb8fKqqUY47OhjtLyDtJ5cGNaY+eeEHyi9p2Qs+166uMPquWEbV kTIWA5Q2MHpklanWLLrzh+QlERLF7QawuuFfsoldA0hEfWhPcgJ/2lelp QcKcarHEmvfbhHXe1CQrdFzIlZaTbmC7GG3R2vrZoRa7dJ+N8aSADPW9O h19a7xP3sflLTRWYLvLmdQsg1cn3HFmXbPR9xSe4nNnOnH1y+tP4/HOVC w==; X-CSE-ConnectionGUID: rB4LFIC0QZWsudICR/VeTA== X-CSE-MsgGUID: n4kJwifhQsSNL49YLxez8w== X-IronPort-AV: E=McAfee;i="6800,10657,11680"; a="88030053" X-IronPort-AV: E=Sophos;i="6.21,248,1763452800"; d="scan'208";a="88030053" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2026 11:25:32 -0800 X-CSE-ConnectionGUID: 5cFL70hKR8WGq8p98FWVaA== X-CSE-MsgGUID: oNCSJpa+Tj289MZWq1bEvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,248,1763452800"; d="scan'208";a="207009704" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.125.136.209]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2026 11:25:31 -0800 Date: Fri, 23 Jan 2026 11:25:31 -0800 Message-ID: <87ms24i11w.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , "Dixit, Ashutosh" , Soham Purkait , igt-dev@lists.freedesktop.org, riana.tauro@intel.com, badal.nilawar@intel.com, kamil.konieczny@intel.com, anshuman.gupta@intel.com, umesh.nerlige.ramappa@intel.com Subject: Re: [PATCH i-g-t v5 1/5] tools: Rename tools/gputop to tools/gputop.src In-Reply-To: <20260123151806.n3isxtvdd55mugws@kamilkon-DESK.igk.intel.com> References: <20260122084526.538837-1-soham.purkait@intel.com> <20260122084526.538837-2-soham.purkait@intel.com> <20260123134528.d7px67wm2a35oc7s@kamilkon-DESK.igk.intel.com> <87o6mkighk.wl-ashutosh.dixit@intel.com> <20260123151806.n3isxtvdd55mugws@kamilkon-DESK.igk.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 23 Jan 2026 07:18:06 -0800, Kamil Konieczny wrote: > > Hi Dixit,, > On 2026-01-23 at 05:52:07 -0800, Dixit, Ashutosh wrote: > > On Fri, 23 Jan 2026 05:45:28 -0800, Kamil Konieczny wrote: > > > > > > Hi Soham, > > > On 2026-01-22 at 14:15:22 +0530, Soham Purkait wrote: > > > > > > I guess it is v6, not v5? > > > > > > > The GPUTOP source directory is renamed to gputop.src > > > > > > s/GPUTOP/gputop/ > > > > under tools/ path. > > > > > > imho here a little more explanation why, like: > > > > > > to compile binary into build/tools/gputop file. > > > > > > This could be done at merge (unless another version is > > > needed). > > > > > > LGTM > > > Reviewed-by: Kamil Konieczny > > > > > > Regards, > > > Kamil > > > > > > > > > > > v1: > > > > - Add meson build files accordingly to generate > > > > the binary under tools. (Kamil) > > > > > > > > Signed-off-by: Soham Purkait > > > > --- > > > > tools/{ => gputop.src}/gputop.c | 0 > > > > Can't we name the directory 'gputop' if we are moving gputop.c into the > > directory. > > > > tools/gputop/ looks better than tools/gputop.src, fwiw. > > > > While we can do it, I like to have build binary in > build/tools/gputop > not > build/tools/gputop/gputop We can't thave the binary in build/tools/gputop if the source is in build/tools/gputop/ ? gputop.src is fine if it can't be done, just thought I'll mention it. > > This folder could have other name, is 'gpu_top' good? > > Regards, > Kamil > > > > > > > tools/gputop.src/meson.build | 1 + > > > > tools/{gputop => gputop.src}/utils.c | 0 > > > > tools/{gputop => gputop.src}/utils.h | 0 > > > > tools/{gputop => gputop.src}/xe_gputop.c | 0 > > > > tools/{gputop => gputop.src}/xe_gputop.h | 0 > > > > tools/meson.build | 11 ++++++----- > > > > 7 files changed, 7 insertions(+), 5 deletions(-) > > > > rename tools/{ => gputop.src}/gputop.c (100%) > > > > create mode 100644 tools/gputop.src/meson.build > > > > rename tools/{gputop => gputop.src}/utils.c (100%) > > > > rename tools/{gputop => gputop.src}/utils.h (100%) > > > > rename tools/{gputop => gputop.src}/xe_gputop.c (100%) > > > > rename tools/{gputop => gputop.src}/xe_gputop.h (100%) > > > > > > > > diff --git a/tools/gputop.c b/tools/gputop.src/gputop.c > > > > similarity index 100% > > [cut]