From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0ED1D10E046 for ; Fri, 5 Jan 2024 13:48:10 +0000 (UTC) From: Jani Nikula To: Lionel Landwerlin , Kamil Konieczny , "igt-dev@lists.freedesktop.org" , "Borah, Chaitanya Kumar" , Juha-Pekka Heikkila , "Garg, Nemesa" , "Roper, Matthew D" Subject: Re: [PATCH] lib: sync i915_pciids.h with kernel In-Reply-To: <423b2282-d63d-4e6f-ae2f-4c490a7390be@intel.com> References: <20231212090841.2060493-1-chaitanya.kumar.borah@intel.com> <20231214143628.xyisz4tovwg3jjo2@kamilkon-desk.igk.intel.com> <20231218161918.dj4b5zqdzwogdbkg@kamilkon-desk.igk.intel.com> <20231219070042.l5yhwd6lmoe7chvn@kamilkon-desk.igk.intel.com> <7297abc4-309a-4ca8-a606-498b3abd0c2a@intel.com> <87plyfykqo.fsf@intel.com> <423b2282-d63d-4e6f-ae2f-4c490a7390be@intel.com> Date: Fri, 05 Jan 2024 15:47:57 +0200 Message-ID: <87mstjyjqq.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, 05 Jan 2024, Lionel Landwerlin wrote: > On 05/01/2024 15:26, Jani Nikula wrote: >> On Fri, 22 Dec 2023, Lionel Landwerlin wrote: >>> The reason we need to differentiate GT2/GT3 skus is that they require a >>> different programming to get performance metrics. >> Please explain why this isn't abstracted in the kernel, and why this >> needs PCI ID level identification in userspace. >> >> BR, >> Jani. > > > You want us to elaborate on "require a different programming" ? My emphasis was on "abstracted in the kernel", and I was kind of quickly asking Explain Like I'm Five. Now I looked at the xml and codegen under lib/i915/perf-configs, and kind of figured why this isn't abstracted in the kernel. :p Never mind. BR, Jani. -- Jani Nikula, Intel