From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A3B1110E32C
 for <igt-dev@lists.freedesktop.org>; Fri,  7 Jan 2022 20:26:32 +0000 (UTC)
Date: Fri, 07 Jan 2022 12:26:30 -0800
Message-ID: <87mtk7gumh.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20220107161920.1643369-2-priyanka.dandamudi@intel.com>
References: <20220107161920.1643369-1-priyanka.dandamudi@intel.com>
 <20220107161920.1643369-2-priyanka.dandamudi@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_gt: Check for shared reset
 domain
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: priyanka.dandamudi@intel.com
Cc: igt-dev@lists.freedesktop.org, saurabhg.gupta@intel.com
List-ID: <igt-dev@lists.freedesktop.org>

On Fri, 07 Jan 2022 08:19:19 -0800, <priyanka.dandamudi@intel.com> wrote:
>
> +bool has_shared_reset_domain(int fd, const intel_ctx_t *ctx, const struct intel_execution_engine2 *e)

e is just a variable for the iterator, do not pass it in, declare locally.

> +	for_each_ctx_engine (fd, ctx, e) {
> +                if (rcs0 && ccs0)
> +                        break;
> +                else if (e->class == I915_ENGINE_CLASS_RENDER && e->instance == 0)
> +                                rcs0 = true;
> +                else if (e->class == I915_ENGINE_CLASS_COMPUTE && e->instance == 0)
> +                                ccs0 = true;
> +        }
> +        return (rcs0 && ccs0);

* Code above uses spaces instead of tabs
* Indentation is wrong
* Check for e->instance is unnecessary, remove it

Let's fix this cosmetic stuff first and then we can actually review the
patch and see how it gels with other series pending review in this area.