From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7C4D6E159 for ; Thu, 14 Oct 2021 15:28:30 +0000 (UTC) Date: Thu, 14 Oct 2021 08:28:30 -0700 Message-ID: <87mtnbhbhd.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20211014081917.15977-1-zbigniew.kempczynski@intel.com> References: <20211014081917.15977-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t 0/7] Prepare IGTs to allow only zero alignment List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org, Petri Latvala List-ID: On Thu, 14 Oct 2021 01:19:10 -0700, Zbigniew Kempczy=F1ski wrote: > > In the future we're planning to allow passing only zero alignment so > this is preparation step to introduce check and disable or fix > igts which uses this constraint. > > v2: rename to gem_allows_obj_alignment() (Ashutosh) > addressing review comments from Ashutosh > For patches 1 through 6: Reviewed-by: Ashutosh Dixit For patch 7, I think the point below from my earlier email is still unaddressed: > So assigning a new offset will cause a new fault-in (bind) but not sure if > it will cause an actual fault-out (unbind). Though I am not sure if there > is actually a way to force it to happen if this doesn't work? Is there a > way to verify that the unbind is actually happening? Maybe if assign the same offset to a different object/page that will cause a fault-out (unbind) followed by a fault-in (bind).