Re: [igt-dev] [PATCH i-g-t v3 1/1] tests/i915/gem_exec_balancer.c - remove unnecessary simulation check

Dixit, Ashutosh
2019-10-10T22:38:48Z

On Thu, 10 Oct 2019 01:06:54 -0700, Chris Wilson wrote:
>
> Quoting Katarzyna Dec (2019-10-10 08:55:28)
> > On Mon, Aug 05, 2019 at 02:30:35PM -0700, Caz Yokoyama wrote:
> >
> > Usual approach for patches it to explain WHY we do things. WHAT is
> > self-explainable by code.
> > Adding commit msg could make patch more noticable.
> >
> > Moreover - I would talk to author of the code what he thinks of this change.
>
> No strong opinion; it's a note to say that this igt focusing on sw
> details rather than hw so the test is unlikely to be useful for early
> bringup.

Agreed, though there doesn't seem to be any reason for not merging the
change either...