Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Matt Roper <matthew.d.roper@intel.com>,
	Matt Atwood <matthew.s.atwood@intel.com>
Subject: Re: [PATCH i-g-t v3 00/11] Implement Wa_14026539277
Date: Mon, 26 Oct 2026 17:10:23 -0300	[thread overview]
Message-ID: <87o6cg9qa8.fsf@intel.com> (raw)
In-Reply-To: <20261023-wa_14026539277-v3-0-b8723ececb7f@intel.com>

Gustavo Sousa <gustavo.sousa@intel.com> writes:

> Wa_14026539277 requires handling from both KMD and userspace (which
> includes IGT).  Do the required changes in IGT for Wa_14026539277.
>
> Since we need to check for Wa_14026539277 as early as during IGT's
> xe_device initialization (i.e. xe_device_get()), some preparatory
> steps are required before the changes specific to the workaround.
>
> So this series does that preliminary work with the initial set of
> patches and then adds the workaround implementation as the final
> patch.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
> Changes in v3:
> - Add tweaks related to igt_warn_on() to avoid CI noise like
>   https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15892/shard-bmg-4/igt@core_setmaster@master-drop-set-user.html .
> - Link to v2: https://patch.msgid.link/20260923-wa_14026539277-v2-0-528b575299d2@intel.com
>
> Changes in v2:
> - The approach remains basically the same, but there were some changes
>   on how the debugfs dumps are cached: now a new struct called
>   xe_wa_cache is used.
> - Besides that, feedback from v1 was incorportated. See the changelogs
>   in individual patches for details.
> - Link to v1: https://patch.msgid.link/20260721-wa_14026539277-v1-0-0c147eeefefa@intel.com
>
> ---
> Gustavo Sousa (11):
>       lib/xe: Move lib/intel_wa to lib/xe/xe_wa
>       lib/xe: Make debugfs_file_has_wa() aware of the debugfs file layout
>       lib/xe: Gather workarounds debugfs dumps in a cache struct
>       lib/xe: Cache workaround information in xe_device
>       lib/xe: Return boolean from xe_wa()
>       lib/xe: Assert that cache is available for xe_wa()
>       tests/intel/xe_pat: Adapt pat_entry_is_wb() to Xe3p
>       lib/xe: Add xe_wa_from_cache()
>       lib/intel_pat: Encapsulate management of xe_device's pat_cache
>       lib/intel_pat: Pass xe_device to xe_get_pat_config()
>       intel: Implement Wa_14026539277
>
>  lib/intel_pat.c       |  43 +++++++--
>  lib/intel_pat.h       |   5 ++
>  lib/intel_wa.c        |  66 --------------
>  lib/intel_wa.h        |  11 ---
>  lib/meson.build       |   2 +-
>  lib/tests/meson.build |   1 +
>  lib/tests/xe_wa.c     |  42 +++++++++
>  lib/tests/xe_wa.h     |  12 +++
>  lib/xe/xe_query.c     |  15 ++--
>  lib/xe/xe_query.h     |  10 ++-
>  lib/xe/xe_wa.c        | 240 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/xe/xe_wa.h        |  19 ++++
>  tests/intel/xe_oa.c   |   4 +-
>  tests/intel/xe_pat.c  |  35 ++++++--
>  14 files changed, 403 insertions(+), 102 deletions(-)
> ---
> base-commit: e40d80d42f9b8f1d22475b7f609252a34cd7355b
> change-id: 20260714-wa_14026539277-c79e97449287

Pushed.  Thanks Matt Atwood and Matt Roper for the reviews!

--
Gustavo Sousa

      parent reply	other threads:[~2026-10-26 20:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 21:02 [PATCH i-g-t v3 00/11] Implement Wa_14026539277 Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 01/11] lib/xe: Move lib/intel_wa to lib/xe/xe_wa Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 02/11] lib/xe: Make debugfs_file_has_wa() aware of the debugfs file layout Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 03/11] lib/xe: Gather workarounds debugfs dumps in a cache struct Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 04/11] lib/xe: Cache workaround information in xe_device Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 05/11] lib/xe: Return boolean from xe_wa() Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 06/11] lib/xe: Assert that cache is available for xe_wa() Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 07/11] tests/intel/xe_pat: Adapt pat_entry_is_wb() to Xe3p Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 08/11] lib/xe: Add xe_wa_from_cache() Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 09/11] lib/intel_pat: Encapsulate management of xe_device's pat_cache Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 10/11] lib/intel_pat: Pass xe_device to xe_get_pat_config() Gustavo Sousa
2026-10-23 21:02 ` [PATCH i-g-t v3 11/11] intel: Implement Wa_14026539277 Gustavo Sousa
2026-10-23 22:43 ` ✓ Xe.CI.BAT: success for Implement Wa_14026539277 (rev3) Patchwork
2026-10-23 23:10 ` ✓ i915.CI.BAT: " Patchwork
2026-10-24  8:15 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-10-26 19:53   ` Gustavo Sousa
2026-10-24  9:18 ` ✗ i915.CI.Full: " Patchwork
2026-10-26 19:56   ` Gustavo Sousa
2026-10-26 20:10 ` Gustavo Sousa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6cg9qa8.fsf@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=matthew.s.atwood@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox