From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52129D74ED8 for ; Fri, 23 Jan 2026 13:52:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CF1610EAF3; Fri, 23 Jan 2026 13:52:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="YqNeZBHx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0599D10EAF3 for ; Fri, 23 Jan 2026 13:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769176329; x=1800712329; h=date:message-id:from:to:subject:in-reply-to:references: mime-version; bh=Wp24GLHZ64/Xaz30CSazCf8qOAd44t/PBgPnavTW714=; b=YqNeZBHxv7pijzGuVZGHZBD1S7D9X0AFs/dzTgrpbeTb3mVvYuE1bx1R HixkuZHIyCEuMRjrdM8oYEC0Ugbs0s/zBek5IyV5D1FEdEQcMtR81CJes eZPm38xmEPjloXEzwr9Sbp4I4d3Qnfm/CpZ9lKvS4/6V66HUse+14nfIP V0esmIC27H0G/uCnWTsv6Rn6d4ykqdjjRjtz4S+F6i5bw2wS286Pqzy05 4x5JX95qRHcxP+j0xtmbwwsUBv0pBCcQAAcyiLaFOxkRZsQC5lBppN/VK Guyr76rJfKQDyxNOhAjyRZr8Levxn8qQfFDX1nLMG1M3PLVZYy6qO8S5u w==; X-CSE-ConnectionGUID: PhwbtsEBS1e+tNxk1F8VjA== X-CSE-MsgGUID: S63HzsgCR9GI8bs/EmWVCA== X-IronPort-AV: E=McAfee;i="6800,10657,11680"; a="81057312" X-IronPort-AV: E=Sophos;i="6.21,248,1763452800"; d="scan'208";a="81057312" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2026 05:52:08 -0800 X-CSE-ConnectionGUID: FSdjkWJaSSOc/bQWjstVyg== X-CSE-MsgGUID: GjhKtBcWT0aYckovS2QGgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,248,1763452800"; d="scan'208";a="206138959" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.125.136.209]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2026 05:52:08 -0800 Date: Fri, 23 Jan 2026 05:52:07 -0800 Message-ID: <87o6mkighk.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , Soham Purkait , igt-dev@lists.freedesktop.org, riana.tauro@intel.com, badal.nilawar@intel.com, kamil.konieczny@intel.com, anshuman.gupta@intel.com, umesh.nerlige.ramappa@intel.com Subject: Re: [PATCH i-g-t v5 1/5] tools: Rename tools/gputop to tools/gputop.src In-Reply-To: <20260123134528.d7px67wm2a35oc7s@kamilkon-DESK.igk.intel.com> References: <20260122084526.538837-1-soham.purkait@intel.com> <20260122084526.538837-2-soham.purkait@intel.com> <20260123134528.d7px67wm2a35oc7s@kamilkon-DESK.igk.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 23 Jan 2026 05:45:28 -0800, Kamil Konieczny wrote: > > Hi Soham, > On 2026-01-22 at 14:15:22 +0530, Soham Purkait wrote: > > I guess it is v6, not v5? > > > The GPUTOP source directory is renamed to gputop.src > > s/GPUTOP/gputop/ > > under tools/ path. > > imho here a little more explanation why, like: > > to compile binary into build/tools/gputop file. > > This could be done at merge (unless another version is > needed). > > LGTM > Reviewed-by: Kamil Konieczny > > Regards, > Kamil > > > > > v1: > > - Add meson build files accordingly to generate > > the binary under tools. (Kamil) > > > > Signed-off-by: Soham Purkait > > --- > > tools/{ => gputop.src}/gputop.c | 0 Can't we name the directory 'gputop' if we are moving gputop.c into the directory. tools/gputop/ looks better than tools/gputop.src, fwiw. > > tools/gputop.src/meson.build | 1 + > > tools/{gputop => gputop.src}/utils.c | 0 > > tools/{gputop => gputop.src}/utils.h | 0 > > tools/{gputop => gputop.src}/xe_gputop.c | 0 > > tools/{gputop => gputop.src}/xe_gputop.h | 0 > > tools/meson.build | 11 ++++++----- > > 7 files changed, 7 insertions(+), 5 deletions(-) > > rename tools/{ => gputop.src}/gputop.c (100%) > > create mode 100644 tools/gputop.src/meson.build > > rename tools/{gputop => gputop.src}/utils.c (100%) > > rename tools/{gputop => gputop.src}/utils.h (100%) > > rename tools/{gputop => gputop.src}/xe_gputop.c (100%) > > rename tools/{gputop => gputop.src}/xe_gputop.h (100%) > > > > diff --git a/tools/gputop.c b/tools/gputop.src/gputop.c > > similarity index 100% > > rename from tools/gputop.c > > rename to tools/gputop.src/gputop.c > > diff --git a/tools/gputop.src/meson.build b/tools/gputop.src/meson.build > > new file mode 100644 > > index 000000000..ec39f4c7a > > --- /dev/null > > +++ b/tools/gputop.src/meson.build > > @@ -0,0 +1 @@ > > +gputop_src = files('gputop.c') > > diff --git a/tools/gputop/utils.c b/tools/gputop.src/utils.c > > similarity index 100% > > rename from tools/gputop/utils.c > > rename to tools/gputop.src/utils.c > > diff --git a/tools/gputop/utils.h b/tools/gputop.src/utils.h > > similarity index 100% > > rename from tools/gputop/utils.h > > rename to tools/gputop.src/utils.h > > diff --git a/tools/gputop/xe_gputop.c b/tools/gputop.src/xe_gputop.c > > similarity index 100% > > rename from tools/gputop/xe_gputop.c > > rename to tools/gputop.src/xe_gputop.c > > diff --git a/tools/gputop/xe_gputop.h b/tools/gputop.src/xe_gputop.h > > similarity index 100% > > rename from tools/gputop/xe_gputop.h > > rename to tools/gputop.src/xe_gputop.h > > diff --git a/tools/meson.build b/tools/meson.build > > index 8185ba160..521607a4c 100644 > > --- a/tools/meson.build > > +++ b/tools/meson.build > > @@ -70,11 +70,6 @@ if libudev.found() > > install : true) > > endif > > > > -executable('gputop', 'gputop.c', > > - install : true, > > - install_rpath : bindir_rpathdir, > > - dependencies : [lib_igt_drm_clients,lib_igt_drm_fdinfo,lib_igt_profiling,math]) > > - > > intel_l3_parity_src = [ 'intel_l3_parity.c', 'intel_l3_udev_listener.c' ] > > executable('intel_l3_parity', sources : intel_l3_parity_src, > > dependencies : tool_deps, > > @@ -123,3 +118,9 @@ endif > > subdir('i915-perf') > > subdir('xe-perf') > > subdir('null_state_gen') > > + > > +subdir('gputop.src') > > +executable('gputop', sources : gputop_src, > > + install : true, > > + install_rpath : bindir_rpathdir, > > + dependencies : [lib_igt_drm_clients,lib_igt_drm_fdinfo,lib_igt_profiling,math],) > > -- > > 2.34.1 > >