From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D73CCA101F for ; Thu, 11 Sep 2025 01:45:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B393C10E196; Thu, 11 Sep 2025 01:45:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Wwb6Msju"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EFC010E196 for ; Thu, 11 Sep 2025 01:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757555124; x=1789091124; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=UZXNxhrdFa55PWTloGJQ7kjVVfeQ/Vclm9Uo8sP9Yp0=; b=Wwb6Msjul/7ombcpA2zWV8bQ53K6RNyuIfCUhP1NoYO4SQon/RxTv/W5 p+Uxm4DEzGp/VgWfDGc5gpDI0QmbAJvlRFtD4Bj0ZI3ytzmRWyjErvBDH +fzFAvhmZyrL3T+o4nxRsT6iP4oeRjTQHGBQJCgtqwEhNi76qkXU03ucH Qtn6K0Djo2PIrqz99ULK+GgwFJisANfNuL7PDDwfjad0oJp6RE2V2DA7L 9TmGGzWlJ24gYH15sB1MDeZkMzPRWO4J/+COQ1Uw4g4TpT36bW99aTfwy Fw9zsI4dWv8+PaglRfsQv2LdK1w7cdUImjItB1gvAVBpgex45nJ5Ddu5N w==; X-CSE-ConnectionGUID: txdib7IrRimnhFuG3x16Xg== X-CSE-MsgGUID: ZN+snHyYRdSr9hYmu4IjpQ== X-IronPort-AV: E=McAfee;i="6800,10657,11549"; a="62510462" X-IronPort-AV: E=Sophos;i="6.18,256,1751266800"; d="scan'208";a="62510462" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2025 18:45:24 -0700 X-CSE-ConnectionGUID: T/vMlbTNQuK3KpjXBg/zDg== X-CSE-MsgGUID: rteQcuBrTnO1HGcZ4qRNQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,256,1751266800"; d="scan'208";a="173122547" Received: from nrichaud-mobl1.ger.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.85.164]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2025 18:45:24 -0700 Date: Wed, 10 Sep 2025 18:45:22 -0700 Message-ID: <87o6rh69u5.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH i-g-t 1/1] tests/intel/xe_eu_stall: Use the fastest sampling rate from the query IOCTL data In-Reply-To: <6701e36ca7746494aa9358448652be7fc819d51f.1757554496.git.harish.chegondi@intel.com> References: <6701e36ca7746494aa9358448652be7fc819d51f.1757554496.git.harish.chegondi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 10 Sep 2025 18:36:13 -0700, Harish Chegondi wrote: > > Earlier commit 157b34af65168 ("tests/intel/xe_eu_stall: Use default sampling rate > from the query IOCTL data") used a mid sampling rate from those returned > from the query IOCTL, if the user doesn't pass a sampling rate. However, some > GPUs, sometimes, aren't generating any EU stall data with the mid sampling > rate with 100 iterations of GPGPU fill. So, Use the fastest sampling rate > from the query IOCTL data so that there is always some EU stall data > generated with GPGPU fill. Reviewed-by: Ashutosh Dixit > > Cc: Ashutosh Dixit > Signed-off-by: Harish Chegondi > --- > tests/intel/xe_eu_stall.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tests/intel/xe_eu_stall.c b/tests/intel/xe_eu_stall.c > index f09e525eb..f5c57a9b3 100644 > --- a/tests/intel/xe_eu_stall.c > +++ b/tests/intel/xe_eu_stall.c > @@ -648,7 +648,7 @@ igt_main_args("e:g:o:r:u:w:", long_options, help_str, opt_handler, NULL) > { > bool blocking_read = true; > struct xe_device *xe_dev; > - int drm_fd, idx; > + int drm_fd; > uint32_t devid; > struct stat sb; > > @@ -665,10 +665,8 @@ igt_main_args("e:g:o:r:u:w:", long_options, help_str, opt_handler, NULL) > query_eu_stall_data = xe_dev->eu_stall; > igt_assert(query_eu_stall_data->num_sampling_rates > 0); > /* If the user doesn't pass a sampling rate, use a mid sampling rate */ > - if (p_rate == 0) { > - idx = query_eu_stall_data->num_sampling_rates / 2; > - p_rate = query_eu_stall_data->sampling_rates[idx]; > - } > + if (p_rate == 0) > + p_rate = query_eu_stall_data->sampling_rates[0]; > > if (output_file) { > output = fopen(output_file, "w"); > -- > 2.51.0 >