From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18D35C54ED0 for ; Fri, 23 May 2025 16:06:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD1F910E82C; Fri, 23 May 2025 16:06:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WbFoL32R"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE55F10E82E for ; Fri, 23 May 2025 16:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748016379; x=1779552379; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=yAGOqKi7JDjaN6W8zv/Ch+RisFivyCS32lOgLNMgH0o=; b=WbFoL32Rv5Kv7J14XUffKnlQQb1wS/NxjHH9v/hLFTRfmpPUaFUDmBau c1D52wSKOapjaNna1hBxYkFfAR+JDLokctCb+zHoaFrs63hlt0rm/gYcM bhIkvAF8y3p0ZJPMuI4ky+xh90LOJYt6aySFd4J+J/7eD6tG8CTVYESuQ RuoxcAfSUxNI4kGkkssAg/62TRb9cDYDZ7fIKLdat/I3q+EB+0dTDvr80 Yc55F4I/6JN7ooFhHMiMfYu+3xfvP2RshBLAOz/Vv2JokY2y43t2DadA1 qb/WZjwlRTsyyO+zB+OA1m6K7xqulXfmhDTqDIyf2hjgZRBSaf7gkUfVv A==; X-CSE-ConnectionGUID: IeqNTtyqR1qsjn4KMk+ebw== X-CSE-MsgGUID: qqM3yYNYTtaIre9XTo6g4Q== X-IronPort-AV: E=McAfee;i="6700,10204,11441"; a="53738741" X-IronPort-AV: E=Sophos;i="6.15,309,1739865600"; d="scan'208";a="53738741" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2025 09:06:18 -0700 X-CSE-ConnectionGUID: uKY/WVe2RRSQeP9Y2/HNBQ== X-CSE-MsgGUID: VJPFO9N1TxeU48CxaBaa7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,309,1739865600"; d="scan'208";a="178324576" Received: from ljesse-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.183.7]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2025 09:06:18 -0700 Date: Fri, 23 May 2025 09:06:17 -0700 Message-ID: <87o6vjjoqu.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Bernatowicz, Marcin" Cc: "Kolakowski, Jakub1" , "igt-dev@lists.freedesktop.org" , "Chegondi, Harish" , Adam Miszczak , "Laguna, Lukasz" Subject: Re: [PATCH i-g-t] tests/intel/xe_eu_stall: Skip test on SR-IOV VF In-Reply-To: <9696a2b7-e85a-4fc1-b400-c16f4df1c31a@linux.intel.com> References: <20250522172441.3914198-1-jakub1.kolakowski@intel.com> <9eb53198-a170-4cb2-9f31-db5f3dbeb60d@linux.intel.com> <86c5c139-26e7-4862-85ae-3b838c514cf1@linux.intel.com> <9696a2b7-e85a-4fc1-b400-c16f4df1c31a@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 23 May 2025 06:56:52 -0700, Bernatowicz, Marcin wrote: > > > > On 5/23/2025 3:11 PM, Bernatowicz, Marcin wrote: > > Hi Jakub, > > > > On 5/23/2025 2:23 PM, Kolakowski, Jakub1 wrote: > >> Hi Marcin, > >> I was trying to align the code of the IGT test with kernel code, where > >> we have an explicit check for SR-IOV VF. > >> See https://gitlab.freedesktop.org/drm/tip/-/ > >> commit/1d622a4fe2b9a30cd4af2e858d793d05f8a82774 > >> > And with this approach, the kernel check itself isn't really being tested= ;) > -- > marcin>> Jakub Marcin is correct. This patch is wrong, IGT should check for -ENODEV returned from kernel. Both opening a stream as well as the EU stall query will return -ENODEV on SRIOV VF. @Chegondi, Harish: weren't you adding something for EU stall query if it's not there? > > > > Still, I wonder if relying on VF checks is the best long-term approach - > > we might enable the feature on a VF at some point, and the test would > > keep skipping. > > What about other apps using this feature - how should they detect > > availability? > > If they just try to use it on a VF, do they get ENODEV or something els= e? > > Wouldn=A2t it be more robust to base this on a real feature check from > > userspace if possible? > > -- > > marcin