From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFE7FC54E90 for ; Wed, 21 May 2025 20:12:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 741D110E6E8; Wed, 21 May 2025 20:12:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JI3tTtxO"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id BABF510E6E8 for ; Wed, 21 May 2025 20:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747858353; x=1779394353; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=pO/GrmgGUIfuA11c23N+NKkVU7D39qqRbbwO0A29ZWo=; b=JI3tTtxOCwOzaGP1dtngTw8QzGD/X5xTTf4+MpWAPxRS7clBBj2CFhF4 ea0KqCeBI8FshEGBQIOqlSqbA2A7VmHSXmWX/sqk1rHdv0s7loMqnEMXu C7tvXyTGFroSGqlI93xKR/pwZGMVmHttTnakdqJGcVlmYpEIC6Qz7hRL4 O7ZDjkF9J7voOxBvO7ZpHEcLiqswWK8oNQTtlKZJsaBBvGIcRK6LCtLrk 6q5ye8Bt1MhZPWUrenyQlGFtx6/sI7CLSu8stgwBgHr00hhzYmrG3E1H2 3WhqhDxmnSK9NzmFBcr7qvWDdnNCzKWdkQsrZZ0AtyAn04Y+K+IWDh3o7 Q==; X-CSE-ConnectionGUID: V5mb2c6jS4W0P6yRLdLArg== X-CSE-MsgGUID: /DacgiUORTG9lp0tPoFpew== X-IronPort-AV: E=McAfee;i="6700,10204,11440"; a="49734915" X-IronPort-AV: E=Sophos;i="6.15,304,1739865600"; d="scan'208";a="49734915" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2025 13:12:30 -0700 X-CSE-ConnectionGUID: DT/dH77IRS6F9kFueJm56w== X-CSE-MsgGUID: /e+OvZj7QK2Kvv5JBkq2kg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,304,1739865600"; d="scan'208";a="145487802" Received: from sdolai-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.192.35]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2025 13:12:29 -0700 Date: Wed, 21 May 2025 13:12:28 -0700 Message-ID: <87o6vl4tar.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH] tests/intel/xe_oa: Ignore other errors when looking for buffer overflow In-Reply-To: <20250520195249.326080-2-umesh.nerlige.ramappa@intel.com> References: <20250520195249.326080-2-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 20 May 2025 12:52:50 -0700, Umesh Nerlige Ramappa wrote: > > Occassionally other error bits will result in EIO and prematurely end > the buffer-fill test. For this test, ignore other errors. > > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4565 =46rom CI buglog it looks like, a REPORT_LOST (0x1) status is returned befo= re BUFFER_OVERFLOW (0x2) status? Patch generally looks ok, but a question below. > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 73841a359daf..2022c5cb3955 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -2520,7 +2520,6 @@ test_buffer_fill(const struct drm_xe_engine_class_i= nstance *hwe) > char *buf =3D malloc(1024); > bool overflow_seen; > u32 oa_status; > - int len; > > igt_debug("oa_period %s\n", pretty_print_oa_period(oa_period)); > stream_fd =3D __perf_open(drm_fd, ¶m, true /* prevent_pm */); > @@ -2535,16 +2534,22 @@ test_buffer_fill(const struct drm_xe_engine_class= _instance *hwe) > > errno =3D 0; > /* Read 0 bytes repeatedly until you see an EIO */ > - while ((len =3D read(stream_fd, buf, 0)) =3D=3D -1 && (errno =3D=3D EIN= TR || errno =3D=3D ENOSPC)) { > + while (-1 =3D=3D read(stream_fd, buf, 0)) { > + if (errno =3D=3D EIO) { > + oa_status =3D get_stream_status(stream_fd); > + overflow_seen =3D oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW; > + if (overflow_seen) > + break; > + } > usleep(100); > } > - igt_assert_eq(len, -1); > - igt_assert_eq(errno, EIO); > + igt_assert(overflow_seen); > > - /* Ensure buffer overflowed */ > + /* Make sure the buffer overflow is cleared */ > + read(stream_fd, buf, 0); How does the buffer overflow status get cleared? We are still doing 0 size = reads? > oa_status =3D get_stream_status(stream_fd); > overflow_seen =3D oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW; > - igt_assert(overflow_seen); > + igt_assert_eq(overflow_seen, 0); > > __perf_close(stream_fd); > } > -- > 2.43.0 > Thanks. -- Ashutosh