From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/3] tests/i915/gem_softpin: Add safe-start test
Date: Thu, 06 Jan 2022 05:20:02 -0800 [thread overview]
Message-ID: <87o84p9f25.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <Yda8phW7hK35Jzeb@zkempczy-mobl2>
On Thu, 06 Jan 2022 01:55:50 -0800, Zbigniew Kempczyński wrote:
>
> On Wed, Jan 05, 2022 at 06:24:14PM -0800, Dixit, Ashutosh wrote:
> > On Tue, 04 Jan 2022 22:49:44 -0800, Zbigniew Kempczyński wrote:
> > >
> > > + offset1 = gem_detect_min_start_offset_for_region(i915, region1);
> > > + offset2 = gem_detect_min_start_offset_for_region(i915, region2);
> > > + alignment = gem_detect_safe_alignment(i915);
> > > + igt_debug("safe alignment: %llx\n", (long long) alignment);
> > > + igt_debug("safe start offset: %llx\n",
> > > + (long long) gem_detect_safe_start_offset(i915));
> > > + igt_debug("minimum object1 start offset: %llx\n", (long long) offset1);
> > > + igt_debug("minimum object2 start offset: %llx\n", (long long) offset2);
> >
> > Maybe also add print for the min_alignment value here?
>
> You want to print minimum alignment for same region?
Yes, just the min alignment for the pair or regions above.
Otherwise please go ahead and merge. The series is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2022-01-06 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 6:49 [igt-dev] [PATCH i-g-t 0/3] Add start offset and alignment detection Zbigniew Kempczyński
2022-01-05 6:49 ` [igt-dev] [PATCH i-g-t 1/3] lib/intel_memory_region: " Zbigniew Kempczyński
2022-01-06 2:23 ` Dixit, Ashutosh
2022-01-06 9:45 ` Zbigniew Kempczyński
2022-01-05 6:49 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915/gem_softpin: Add safe-start test Zbigniew Kempczyński
2022-01-06 2:24 ` Dixit, Ashutosh
2022-01-06 9:55 ` Zbigniew Kempczyński
2022-01-06 13:20 ` Dixit, Ashutosh [this message]
2022-01-05 6:49 ` [igt-dev] [PATCH i-g-t 3/3] tests/fast-feedback.testlist: Add gem_softpin@safe-start subtest Zbigniew Kempczyński
2022-01-05 7:39 ` [igt-dev] ✓ Fi.CI.BAT: success for Add start offset and alignment detection (rev6) Patchwork
2022-01-05 8:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-12-30 18:26 [igt-dev] [PATCH i-g-t 0/3] Add start offset and alignment detection Zbigniew Kempczyński
2021-12-30 18:26 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915/gem_softpin: Add safe-start test Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o84p9f25.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox