From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 91B7C6E207
 for <igt-dev@lists.freedesktop.org>; Fri,  6 Aug 2021 21:48:21 +0000 (UTC)
Date: Fri, 06 Aug 2021 14:48:19 -0700
Message-ID: <87o8aautwc.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20210806134145.24634-19-zbigniew.kempczynski@intel.com>
References: <20210806134145.24634-1-zbigniew.kempczynski@intel.com>
 <20210806134145.24634-19-zbigniew.kempczynski@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t v4 18/56] tests/gem_exec_balancer: Adopt
 to use allocator
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

On Fri, 06 Aug 2021 06:41:07 -0700, Zbigniew Kempczy=F1ski wrote:
>
> For newer gens we're not able to rely on relocations. Adopt to use
> offsets acquired from the allocator.

One minor fix below, with that:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> @@ -1334,11 +1347,13 @@ static void __bonded_nohang(int i915, const intel=
_ctx_t *ctx,
>	};
>	igt_spin_t *time, *spin;
>	const intel_ctx_t *load;
> +	uint64_t ahnd0 =3D get_reloc_ahnd(i915, 0), ahnd;
>
>	load =3D ctx_create_balanced(i915, siblings, count);
>	gem_context_set_priority(i915, load->id, 1023);
> +	ahnd =3D get_reloc_ahnd(i915, ctx->id);

ahnd =3D get_reloc_ahnd(i915, load->id);

>
> -	spin =3D igt_spin_new(i915, .ctx =3D load, .engine =3D 1);
> +	spin =3D igt_spin_new(i915, .ahnd =3D ahnd, .ctx =3D load, .engine =3D =
1);