From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 29 Jul 2021 19:03:11 -0700 Message-ID: <87o8akeexs.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <87im0u3wtc.wl-ashutosh.dixit@intel.com> References: <20210728103041.1669985-1-matthew.auld@intel.com> <87im0u3wtc.wl-ashutosh.dixit@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t v2 01/11] lib/i915/gem_mman: add FIXED mmap mode List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Matthew Auld Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-ID: On Wed, 28 Jul 2021 15:20:15 -0700, Dixit, Ashutosh wrote: > > On Wed, 28 Jul 2021 03:30:31 -0700, Matthew Auld wrote: > > > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c > > index 4b4f2114..e2514f0c 100644 > > --- a/lib/i915/gem_mman.c > > +++ b/lib/i915/gem_mman.c > > @@ -497,6 +497,43 @@ void *gem_mmap_offset__cpu(int fd, uint32_t handle, uint64_t offset, > > return ptr; > > } > > > > +#define LOCAL_I915_MMAP_OFFSET_FIXED 4 > > At the minimum for now let's get rid of the LOCAL_ prefix here. Even if > this appears in i915_drm.h later, gcc will only complain if the value > diverges. We just merged lib/i915/i915_drm_local.h so any declarations which we are expecting appear to later appear in i915_drm.h should be added there, without the LOCAL_ prefix. So they should be added just as we are expecting them to appear later in i915_drm.h. Thanks. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev