From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6708CCD37AC for ; Wed, 13 May 2026 21:38:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA71510E086; Wed, 13 May 2026 21:38:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CYcJbCAg"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D94010E086 for ; Wed, 13 May 2026 21:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778708319; x=1810244319; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=L9F5Obbowrbpz31av/v+X7wqnv0cxPtQgIkL6WZfF8c=; b=CYcJbCAgvyLz/GxkMa4O9SkdUJrQn++TixBq9OqDoF6/fNBC1fHbtpkz FN2+DEdhZxJOXPxkBSoXYbkGFSNtHRlhcFynJIuP1hiQCfgzWBzGph1Os kO1qLd9eROmwR4dXgw22D5JH68qXcY3eLDzwjDyQkMtB/r2LRu0w/CCiU 9gI08v7xqvAl+iVnBhR+yEBtouT3fw7u2OIqLbAm6eRpeE5d8xD/zX1zu TJ9ipx7RZDCkaSigJPU7CARDdU/kL3tBzcesQhIvpFS5cX/ESyurR11hA CdExKRLrEnJXiOSJqhk8eKvMp32XktB4GEvMFIyUFhRWSU7WOxZoHD+kk Q==; X-CSE-ConnectionGUID: ca0t11XORJ+8Qok1sEY51A== X-CSE-MsgGUID: 5BVn1inqRj2khHfnIiI3Ug== X-IronPort-AV: E=McAfee;i="6800,10657,11785"; a="78790359" X-IronPort-AV: E=Sophos;i="6.23,233,1770624000"; d="scan'208";a="78790359" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 14:38:39 -0700 X-CSE-ConnectionGUID: gR2Lv5eMSf6hDvLEM6XpoQ== X-CSE-MsgGUID: nzO0C92URjWxWriOEf4tgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,233,1770624000"; d="scan'208";a="243185163" Received: from chussx-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.35.95]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 14:38:39 -0700 Date: Wed, 13 May 2026 14:38:38 -0700 Message-ID: <87pl2zt2g1.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: Subject: Re: [PATCH v7 2/2] tests/intel/xe_oa: Wa_14026633728 In-Reply-To: <87o6iq7d8q.wl-ashutosh.dixit@intel.com> References: <20260508021329.876072-1-shekhar.chauhan@intel.com> <20260508021329.876072-3-shekhar.chauhan@intel.com> <87o6iq7d8q.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Thu, 07 May 2026 21:10:29 -0700, Dixit, Ashutosh wrote: > > On Thu, 07 May 2026 19:13:29 -0700, Shekhar Chauhan wrote: > > > > For MERTOA in CRI, oa buffer can be in device memory. Because of slower > > device mem access, OA exponent values lower than 8 can result in buffer > > overflows. Bump the OA exponent value. > > Reviewed-by: Ashutosh Dixit > > > > > Signed-off-by: Shekhar Chauhan > > --- > > tests/intel/xe_oa.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > > index 988c46df6..2f73b5210 100644 > > --- a/tests/intel/xe_oa.c > > +++ b/tests/intel/xe_oa.c > > @@ -24,6 +24,7 @@ > > #include "igt_device.h" > > #include "igt_syncobj.h" > > #include "igt_sysfs.h" > > +#include "intel_wa.h" > > #include "xe/xe_ioctl.h" > > #include "xe/xe_query.h" > > #include "xe/xe_oa.h" > > @@ -2671,6 +2672,18 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > > int len, check_idx; > > u32 oa_status; > > > > + /* > > + * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory. > > + * Because of slower device mem access, OA exponent values lower than 8 > > + * can result in buffer overflows. Also, update the value of oa_exponent > > + * in properties[]. > > + */ > > + if (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && > > + igt_has_intel_wa(drm_fd, "14026633728")) { Incidentally, there's a bug here: the way the code is in the lib, there should be a > 0 check here. Hopefully we'll fix the lib. > > + oa_exponent = max(oa_exponent, 8); > > + properties[9] = oa_exponent; > > + } > > + > > igt_assert(buf); > > > > igt_debug("Ready to read about %u bytes\n", buf_size); > > -- > > 2.53.0 > >