From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2FD4710E487 for ; Thu, 17 Aug 2023 13:23:14 +0000 (UTC) Date: Thu, 17 Aug 2023 06:23:12 -0700 Message-ID: <87pm3lsszj.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , igt-dev@lists.freedesktop.org, Alan Previn , Kamil Konieczny In-Reply-To: <20230816142739.k2ycx6vn5rrx33rt@kamilkon-desk1> References: <20230815173659.1208384-1-alan.previn.teres.alexis@intel.com> <20230816142739.k2ycx6vn5rrx33rt@kamilkon-desk1> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915: Add a helper lib to read mmio registers via ioctl List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Wed, 16 Aug 2023 07:27:39 -0700, Kamil Konieczny wrote: > Hi Alan/Kamil, > Hi Alan, > > On 2023-08-15 at 10:36:59 -0700, Alan Previn wrote: > > Add a helper lib function to call DRM_IOCTL_I915_REG_READ to > > read whitelisted registers. > > > > Signed-off-by: Alan Previn > > --- > > lib/i915/i915_reg_read_ioctl.c | 34 ++++++++++++++++++++++++++++++++++ > ---------------- ^^^^^^^^^^^^^^ > > imho better name would be i915_mmio_reg > > > lib/i915/i915_reg_read_ioctl.h | 9 +++++++++ Can't this just go in lib/ioctl_wrappers.*? Do we need a new file for this? Thanks. -- Ashutosh