From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6678E10E778
 for <igt-dev@lists.freedesktop.org>; Tue, 20 Sep 2022 19:57:31 +0000 (UTC)
Date: Tue, 20 Sep 2022 12:57:29 -0700
Message-ID: <87pmfpddjq.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
In-Reply-To: <20220919144408.251981-4-riana.tauro@intel.com>
References: <20220919144408.251981-1-riana.tauro@intel.com>
 <20220919144408.251981-4-riana.tauro@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t v2 3/8] lib/igt_power: Add hwmon
 interface to igt_power
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 19 Sep 2022 07:44:03 -0700, Riana Tauro wrote:
>
> Modify igt_power to expose functions to read energy, power
> using hwmon and rapl interface

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> +/**
> + * igt_power_get_mJ:
> + * @igt_power : power struct
> + * @power_sample: sample of energy and time
> + *
> + * Calculates energy difference between two power samples

Maybe quickly mention the units of energy here too, for hwmon it is micro
joules and rapl it's joules.

> + *
> + * Returns
> + * energy in mJ from hwmon/rapl
> + */
> +double igt_power_get_mJ(const struct igt_power *power,
> +			const struct power_sample *p0, const struct power_sample *p1)
> +{
> +	if (power->hwmon_fd >= 0)
> +		return (p1->energy - p0->energy) * 1e-3;
> +	else if (power->rapl.fd >= 0)
> +		return ((p1->energy - p0->energy) *  power->rapl.scale) * 1e3;
> +
> +	return 0;
> +}