From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7FA46E415 for ; Wed, 25 Aug 2021 18:48:08 +0000 (UTC) Date: Wed, 25 Aug 2021 11:48:07 -0700 Message-ID: <87pmu1z7h4.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210825075149.81624-1-zbigniew.kempczynski@intel.com> References: <20210825075149.81624-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t] tests/gem_exec_params: Fix context within which batch is executed List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org, Jason Ekstrand List-ID: On Wed, 25 Aug 2021 00:51:49 -0700, Zbigniew Kempczy=F1ski wrote: > > With new intel_ctx_t we're responsible to set execbuf rsvd1 (context) id > field. As same field exists for exec object there's risk to mechanically > set improper field and compiler won't complain. Reviewed-by: Ashutosh Dixit > Signed-off-by: Zbigniew Kempczy=F1ski > Cc: Ashutosh Dixit > Cc: Jason Ekstrand > --- > tests/i915/gem_exec_params.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c > index ba79791a1..d247b8a61 100644 > --- a/tests/i915/gem_exec_params.c > +++ b/tests/i915/gem_exec_params.c > @@ -334,11 +334,11 @@ static void test_larger_than_life_batch(int fd) > const intel_ctx_t *ctx =3D intel_ctx_create_all_physical(fd); > struct drm_i915_gem_exec_object2 exec =3D { > .handle =3D batch_create_size(fd, size), > - .rsvd1 =3D ctx->id, > }; > struct drm_i915_gem_execbuffer2 execbuf =3D { > .buffers_ptr =3D to_user_pointer(&exec), > .buffer_count =3D 1, > + .rsvd1 =3D ctx->id, > }; > > /* > -- > 2.26.0 >