From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 193D36E209
 for <igt-dev@lists.freedesktop.org>; Fri, 30 Jul 2021 01:09:52 +0000 (UTC)
Date: Thu, 29 Jul 2021 18:09:51 -0700
Message-ID: <87pmv0eheo.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <YQJl7pgkajR8K01r@platvala-desk.ger.corp.intel.com>
References: <20210728051700.21223-1-ashutosh.dixit@intel.com>	<YQJl7pgkajR8K01r@platvala-desk.ger.corp.intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915: Add i915_drm_local.h
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

On Thu, 29 Jul 2021 01:25:18 -0700, Petri Latvala wrote:
>
> On Tue, Jul 27, 2021 at 10:17:00PM -0700, Ashutosh Dixit wrote:
> > It is necessary on occasion to add uapi declarations to IGT before they
> > appear in imported kernel uapi headers. This is typically done at present
> > using LOCAL declarations (or #ifndef's) which are dispersed across multiple
> > source and header files. Such declarations sometimes linger on in the code
> > for months or years till someone thinks of cleaning them up.
> >
> > As opposed to this, provide a central location (in i915_drm_local.h) for
> > such early uapi declarations in IGT. These declarations will be added to
> > i915_drm_local.h exactly as they are expected to appear in the kernel uapi
> > headers, i.e. without the LOCAL_ or local_ prefix. They can be cleaned up
> > when the uapi headers are sync'd or they can live on (if they don't
> > conflict with the kernel headers) but at least they will be in a single
> > place and more visible. At least that is the hope.
> >
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Centralizing these should make cleanup easier and happen more
> often.
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Thanks Petri, merged.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev