From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [igt-dev] [UNTESTED RFC] tests: drop openssl dependency in favor of glib sha1 implementation
Date: Wed, 23 Jan 2019 09:56:32 +0200 [thread overview]
Message-ID: <87pnsn3iz3.fsf@intel.com> (raw)
In-Reply-To: <154816244782.1277.8411319537664432112@skylake-alporthouse-com>
On Tue, 22 Jan 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-01-22 12:59:40)
>> We already depend on glib which has sha1, so we don't really need
>> openssl just for sha1.
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> Untested.
>
> Now tested.
>
> I just wish glib was the C library I wished it to be :(
I feel you.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, pushed with a reference to caea9c5b3aa1 ("igt/gem_userptr: Check
read-only mappings") added in the commit message.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-23 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 12:59 [igt-dev] [UNTESTED RFC] tests: drop openssl dependency in favor of glib sha1 implementation Jani Nikula
2019-01-22 13:07 ` Chris Wilson
2019-01-23 7:56 ` Jani Nikula [this message]
2019-01-22 13:35 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-01-22 18:33 ` [igt-dev] ✓ Fi.CI.BAT: success for tests: drop openssl dependency in favor of glib sha1 implementation (rev2) Patchwork
2019-01-22 19:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnsn3iz3.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox