From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t v3 2/2] lib/igt_aux: Enable PM Suspend dbg messages
Date: Thu, 22 Jun 2023 10:52:17 -0700 [thread overview]
Message-ID: <87r0q3s7u6.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230622060228.2885144-3-anshuman.gupta@intel.com>
On Wed, 21 Jun 2023 23:02:28 -0700, Anshuman Gupta wrote:
>
Hi Anshuman,
> @@ -940,6 +950,14 @@ static void igt_aux_enable_pm_suspend_dbg(void)
> igt_warn("Unable to open printk parameters Err:%d\n", errno);
> }
>
> + /* pm_debug_messages depends on CONFIG_PM_SLEEP_DEBUG */
> + if (!faccessat(power_dir, "pm_debug_messages", R_OK | W_OK, 0)) {
> + __pm_debug_messages_state = igt_sysfs_get_boolean(sysfs_fd, "pm_debug_messages");
> + igt_sysfs_set_boolean(power_dir, "pm_debug_messages", true);
> + }
> +
> + igt_install_exit_handler(igt_aux_pm_suspend_dbg_restore_exit_handler);
We already installed this exit handler in Patch 1 (under 'if (sysfs_fd >
0)') so we shouldn't install it twice, correct?
Thanks.
--
Ashutosh
next prev parent reply other threads:[~2023-06-22 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 6:02 [igt-dev] [PATCH i-g-t v3 0/2] PM Suspend debug Anshuman Gupta
2023-06-22 6:02 ` [igt-dev] [PATCH i-g-t v3 1/2] lib/igt_aux: Disable console suspend for suspend test Anshuman Gupta
2023-06-23 18:07 ` Kamil Konieczny
2023-06-22 6:02 ` [igt-dev] [PATCH i-g-t v3 2/2] lib/igt_aux: Enable PM Suspend dbg messages Anshuman Gupta
2023-06-22 17:52 ` Dixit, Ashutosh [this message]
2023-06-23 2:45 ` Gupta, Anshuman
2023-06-23 8:39 ` Anshuman Gupta
2023-06-22 7:00 ` [igt-dev] ✓ Fi.CI.BAT: success for PM Suspend debug (rev3) Patchwork
2023-06-22 15:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-23 10:08 ` [igt-dev] ✓ Fi.CI.BAT: success for PM Suspend debug (rev4) Patchwork
2023-06-23 14:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0q3s7u6.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox