From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3ED2010E123 for ; Thu, 15 Dec 2022 18:27:12 +0000 (UTC) Date: Thu, 15 Dec 2022 10:20:16 -0800 Message-ID: <87r0x01qcf.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Tauro, Riana" In-Reply-To: References: <20221215023110.2436554-1-ashutosh.dixit@intel.com> <20221215023110.2436554-2-ashutosh.dixit@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_sysfs: Generic verification of writable sysfs attributes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Badal Nilawar Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, 15 Dec 2022 03:49:30 -0800, Tauro, Riana wrote: > > On 12/15/2022 8:01 AM, Ashutosh Dixit wrote: > > +/* Sweep the range of values for an attribute to identify matching reads/writes */ > > +static int rw_attr_sweep(igt_sysfs_rw_attr_t *rw) > > +{ > > + uint64_t get, set = rw->start; > > + int num_points = 0; > > + bool ret; > > + > Hi Ashutosh > > Thanks for the clarification regarding the clamp max on the previous rev. > done sweeping igt_debug can be retained outside the while since there is no > break/return anywhere else. > > Though not necessary since it behaves the same. > > Looks good to me > Reviewed-by: Riana Tauro Thanks Riana, I made the above change and merged :)