From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 835086E1F5
 for <igt-dev@lists.freedesktop.org>; Thu, 14 Oct 2021 20:07:44 +0000 (UTC)
Date: Thu, 14 Oct 2021 13:07:37 -0700
Message-ID: <87r1cncquu.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20211014081917.15977-8-zbigniew.kempczynski@intel.com>
References: <20211014081917.15977-1-zbigniew.kempczynski@intel.com>
 <20211014081917.15977-8-zbigniew.kempczynski@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t 7/7] benchmarks/gem_exec_fault: Add
 softpin mode to support gens with ppgtt
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

On Thu, 14 Oct 2021 01:19:17 -0700, Zbigniew Kempczy=F1ski wrote:
>
> @@ -127,9 +151,14 @@ static int loop(uint64_t size, unsigned ring, int re=
ps, int ncpus,
>					obj.alignment =3D 0;
>					gem_execbuf(fd, &execbuf);
>
> -					/* fault out */
> -					obj.alignment =3D 1ull << 63;
> -					__gem_execbuf(fd, &execbuf);
> +					if (ahnd) {
> +						obj.offset =3D get_offset(ahnd, obj.handle, size, 0);
> +						obj.flags |=3D EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRE=
SS;
> +					} else {
> +						/* fault out */
> +						obj.alignment =3D 1ull << 63;
> +						__gem_execbuf(fd, &execbuf);
> +					}

Bug above, __gem_execbuf should be moved out of the else {}.

With the bug fixed this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>