From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C3A289DA4 for ; Mon, 9 Aug 2021 21:06:21 +0000 (UTC) Date: Mon, 09 Aug 2021 14:06:20 -0700 Message-ID: <87r1f21g6r.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210809130533.27759-56-zbigniew.kempczynski@intel.com> References: <20210809130533.27759-1-zbigniew.kempczynski@intel.com> <20210809130533.27759-56-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t v5 55/65] tests/i915_pm_rps: Alter to use no-reloc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org, Petri Latvala List-ID: On Mon, 09 Aug 2021 06:05:23 -0700, Zbigniew Kempczy=F1ski wrote: > > diff --git a/tests/i915/i915_pm_rps.c b/tests/i915/i915_pm_rps.c > index f51a47479..ada06aa94 100644 > --- a/tests/i915/i915_pm_rps.c > +++ b/tests/i915/i915_pm_rps.c > @@ -250,6 +250,10 @@ static void load_helper_run(enum load load) > igt_spin_t *spin[2] =3D {}; > bool prev_load; > uint32_t handle; > + uint64_t ahnd; > + > + intel_allocator_init(); OK, this extra step is needed because there is no igt_constructor here. Also each child process is completely independent. > @@ -542,11 +547,14 @@ static void boost_freq(int fd, int *boost_freqs) > { > int64_t timeout =3D 1; > igt_spin_t *load; > + /* We need to keep dependency spin offset for load->handle */ > + uint64_t ahnd =3D get_simple_l2h_ahnd(fd, 0); > > - load =3D igt_spin_new(fd); > + //get_offset(ahnd, 1000, 0x1000000, 0); Please delete this line, with that: Reviewed-by: Ashutosh Dixit