Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 2/4] tests/intel/xe_oa: Fix waiting for mmaped reports
Date: Sat, 23 Aug 2025 11:47:35 -0700	[thread overview]
Message-ID: <87sehhyiwo.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250823003401.109978-8-umesh.nerlige.ramappa@intel.com>

On Fri, 22 Aug 2025 17:34:04 -0700, Umesh Nerlige Ramappa wrote:
>
> When iterating over reports using a uint32_t pointer, ensure that the
> report size is expressed in 32 bits.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> ---
>  tests/intel/xe_oa.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 35d25150ec7d..745f364e52e9 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -4448,6 +4448,7 @@ static void mmap_wait_for_periodic_reports(void *oa_vaddr, uint32_t n,
>	struct intel_xe_perf_metric_set *test_set = metric_set(hwe);
>	uint64_t fmt = test_set->perf_oa_format;
>	uint32_t num_periodic_reports = 0;
> +	uint32_t report_words = get_oa_format(fmt).size >> 2;
>	uint32_t *reports;
>
>	while (num_periodic_reports < n) {
> @@ -4455,7 +4456,7 @@ static void mmap_wait_for_periodic_reports(void *oa_vaddr, uint32_t n,
>		num_periodic_reports = 0;
>		for (reports = (uint32_t *)oa_vaddr;
>		     reports[0] && oa_timestamp(reports, fmt) && oa_report_is_periodic(reports);
> -		     reports += get_oa_format(fmt).size) {
> +		     reports += report_words) {
>			num_periodic_reports++;
>		}
>	}
> --
> 2.43.0
>

  reply	other threads:[~2025-08-23 18:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-23  0:34 [PATCH i-g-t 0/4] IGT xe_oa fixes, debug and new test Umesh Nerlige Ramappa
2025-08-23  0:34 ` [PATCH i-g-t 1/4] tests/intel/xe_oa: Fix report dumps in sanity check Umesh Nerlige Ramappa
2025-08-23 18:25   ` Dixit, Ashutosh
2025-08-26  0:38     ` Umesh Nerlige Ramappa
2025-08-23  0:34 ` [PATCH i-g-t 2/4] tests/intel/xe_oa: Fix waiting for mmaped reports Umesh Nerlige Ramappa
2025-08-23 18:47   ` Dixit, Ashutosh [this message]
2025-08-23  0:34 ` [PATCH i-g-t 3/4] tests/intel/xe_oa: Add a test for tail address wrap Umesh Nerlige Ramappa
2025-08-25 18:03   ` Dixit, Ashutosh
2025-08-26  0:58     ` Umesh Nerlige Ramappa
2025-08-26  1:06       ` Dixit, Ashutosh
2025-08-23  0:34 ` [PATCH i-g-t 4/4] tests/intel/xe_oa: Add an option to capture ftrace Umesh Nerlige Ramappa
2025-08-23 19:01   ` Dixit, Ashutosh
2025-08-25 17:18     ` Dixit, Ashutosh
2025-08-26  0:47       ` Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sehhyiwo.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox