From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3A7310E1A9 for ; Mon, 10 Jul 2023 06:37:01 +0000 (UTC) Date: Sun, 09 Jul 2023 23:36:59 -0700 Message-ID: <87sf9wgtmc.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Himal Prasad Ghimiray In-Reply-To: <20230710044330.770948-4-himal.prasad.ghimiray@intel.com> References: <20230710044330.770948-1-himal.prasad.ghimiray@intel.com> <20230710044330.770948-4-himal.prasad.ghimiray@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t v9 3/4] tests/xe/xe_guc_pc: Change the sysfs paths List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Upadhyay , igt-dev@lists.freedesktop.org, Badal Nilawar Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Sun, 09 Jul 2023 21:43:29 -0700, Himal Prasad Ghimiray wrote: > > Changes to access sysfs entries under tile directory. > Access freq sysfs from /sys/class/drm/cardX/device/tileN/gtN > path. > > v2: > - Use snprintf instead of sprintf and check error. > - Describe what changes are done. (Kamil) > > v3: > - change order of gt and tile and drop passing tilecount.(Ashutosh) > > v4: > - Rebase > > v5: > - Drop usage of xe_for_each_gt_under_each_tile and use > a function to return gt path. (Ashutosh) > > v6: > - use gt_path instead of func call (Ashutosh) > > v7: > - use new api's for gt sysfs access. > > v8: > - Change assert condition. (Ashutosh) > - Rebase xe_guc_pc pre merge CI failures seem to me to be from a different cause, Badal had sent a patch for this which is not yet merged. I think. Therefore this is also: Reviewed-by: Ashutosh Dixit