From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5BDBE10E76D
 for <igt-dev@lists.freedesktop.org>; Tue, 20 Sep 2022 19:47:49 +0000 (UTC)
Date: Tue, 20 Sep 2022 12:47:47 -0700
Message-ID: <87sfklddzw.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
In-Reply-To: <20220919144408.251981-2-riana.tauro@intel.com>
References: <20220919144408.251981-1-riana.tauro@intel.com>
 <20220919144408.251981-2-riana.tauro@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t v2 1/8] lib/igt_hwmon: Introduce library
 igt_hwmon
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 19 Sep 2022 07:44:01 -0700, Riana Tauro wrote:
>
> igt_hwmon exposes methods to open hwmon directories identified by name

There may be other ways of hwmon directories but identifying by name as a
first step seems fine to me. Also, ok to have hwmon code in separate .c/.h
files so the functionality can be extended later. Therefore this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>