From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6999C10E3D9
 for <igt-dev@lists.freedesktop.org>; Fri,  1 Apr 2022 01:23:57 +0000 (UTC)
Date: Thu, 31 Mar 2022 18:23:56 -0700
Message-ID: <87sfqxh9zn.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
In-Reply-To: <87wng9hjpb.wl-ashutosh.dixit@intel.com>
References: <20220330183259.3003663-1-daniele.ceraolospurio@intel.com>
 <20220330183259.3003663-3-daniele.ceraolospurio@intel.com>
 <87wng9hjpb.wl-ashutosh.dixit@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_kmod: Unload mei modules
 before unloading i915
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org,
 Alexander Usyskin <alexander.usyskin@intel.com>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Thu, 31 Mar 2022 14:54:08 -0700, Dixit, Ashutosh wrote:
>
> On Wed, 30 Mar 2022 11:32:59 -0700, Daniele Ceraolo Spurio wrote:
> >
> > mei_gsc binds to an aux device exposed by i915, so it depends on it and
> > need to be removed before we can unload i915.
> > On platforms with a GSC, the mei components (pxp, hdcp) depend on
> > mei_gsc, so those need to be unloaded first.
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Cc: Alexander Usyskin <alexander.usyskin@intel.com>
> > ---
> >  lib/igt_kmod.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> > index d2ac8a56..28ffe515 100644
> > --- a/lib/igt_kmod.c
> > +++ b/lib/igt_kmod.c
> > @@ -400,6 +400,10 @@ int __igt_i915_driver_unload(const char **who)
> >	const char *aux[] = {
> >		/* gen5: ips uses symbol_get() so only a soft module dependency */
> >		"intel_ips",
> > +		/* mei_gsc uses an i915 aux dev and the other mei mods depend on it */
> > +		"mei_pxp",
> > +		"mei_hdcp",
> > +		"mei_gsc",

Actually come to think of it now, why do we even have this list?
igt_kmod_unload_r() should automatically try to unload any modules which
depend on i915. See 1fbeb61e2695. Or does the aux bus make these modules an
exception?