Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: viswax.krishna.raveendra.talabattula@intel.com
Cc: igt-dev@lists.freedesktop.org, hariom.pandey@intel.com
Subject: Re: [igt-dev] [PATCH] [i-g-t] tests/i915: Remove I915_CACHING_NONE
Date: Sun, 18 Apr 2021 23:42:54 -0700	[thread overview]
Message-ID: <87sg3mpyfl.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210419060928.671111-1-viswax.krishna.raveendra.talabattula@intel.com>

On Sun, 18 Apr 2021 23:09:28 -0700, <viswax.krishna.raveendra.talabattula@intel.com> wrote:
>
> From: Viswa Krishna Raveendra Talabattula <viswax.krishna.raveendra.talabattula@intel.com>
>
> The userptr memory does not support I915_CACHING_NONE(no caching) level
> as per the below commit related to i915 in the kernel
>
> drm/i915: Reject more ioctls for userptr, v2.
>
> Hence removing the cache level of I915_CACHING_NONE from the test case

Instead of dropping the test should we check for -ENXIO return?

> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Viswa Krishna Raveendra Talabattula <viswax.krishna.raveendra.talabattula@intel.com>
> ---
>  tests/i915/gem_userptr_blits.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
> index aad5f141..f0c63535 100644
> --- a/tests/i915/gem_userptr_blits.c
> +++ b/tests/i915/gem_userptr_blits.c
> @@ -2011,7 +2011,6 @@ static void test_sd_probe(int i915)
>  static void test_set_caching(int i915)
>  {
>	const int levels[] = {
> -		I915_CACHING_NONE,
>		I915_CACHING_CACHED,
>	};
>	uint32_t handle;
> --
> 2.30.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-04-19  6:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19  6:09 [igt-dev] [PATCH] [i-g-t] tests/i915: Remove I915_CACHING_NONE viswax.krishna.raveendra.talabattula
2021-04-19  6:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-04-19  6:42 ` Dixit, Ashutosh [this message]
2021-04-19  7:10   ` [igt-dev] [PATCH] [i-g-t] " Surendrakumar Upadhyay, TejaskumarX
2021-05-13  1:46   ` Dixit, Ashutosh
2021-05-17  9:11     ` Petri Latvala
2021-05-17 18:34       ` Dixit, Ashutosh
2021-04-19  7:34 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg3mpyfl.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=hariom.pandey@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=viswax.krishna.raveendra.talabattula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox