From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFC6C6EA3D for ; Wed, 15 Jan 2020 17:03:30 +0000 (UTC) Date: Wed, 15 Jan 2020 09:03:30 -0800 Message-ID: <87sgkgwt25.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20200115162740.GE18295@ideak-desk.fi.intel.com> References: <037121df1ee6fcf1fa92ea4a7fb6ba31b39e80ac.1578720512.git.ashutosh.dixit@intel.com> <20200115162740.GE18295@ideak-desk.fi.intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 2/2] i915/treewide: Replace gem_mmap__gtt() by gem_mmap__device_coherent() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: imre.deak@intel.com Cc: igt-dev@lists.freedesktop.org List-ID: On Wed, 15 Jan 2020 08:27:40 -0800, Imre Deak wrote: > > Hi, > > On Fri, Jan 10, 2020 at 09:36:53PM -0800, Ashutosh Dixit wrote: > > As another step towards supporting GPU's without mappable aperture, > > globally replace gem_mmap__gtt() by gem_mmap__device_coherent(). This > > will not affect GPU's with a mappable aperture but will fix tests on > > GPU's without a mappable aperture through the use of WC mapping, > > unless those tests test actual features available via the aperture. > > igt_draw_rect() depends on detiling via the aperture. I'd suggest > converting first only the places that don't depend on this and follow-up > with the rest once we have a way to do the detiling in another way. Patch 1/2 was supposed to take care of this so that at least platforms with mappable aperture don't break. Platforms without mappable aperture anyway need to figure out a different way, but I agree, you are probably saying just don't touch them in this patch. In any case we are not moving forward with this approach at this point because of Chris' comments. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev