Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_frontbuffer_tracking: Check compression state on all gens

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 28 Sep 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The compression status has been available on all platforms
> since commit 3fd5d1ecae2d ("drm/i915: Implement fbc_status
> "Compressing" info for all platforms") in the kernel. Make
> use of it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

On the series,

Acked-by: Jani Nikula <jani.nikula@intel.com>

didn't review all the details.

I guess we've deciced in the past it's fine to break testing for older
kernels...?


> ---
>  tests/i915/kms_frontbuffer_tracking.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
> index 9518c706d87d..bdf718cf073a 100644
> --- a/tests/i915/kms_frontbuffer_tracking.c
> +++ b/tests/i915/kms_frontbuffer_tracking.c
> @@ -1415,17 +1415,11 @@ static bool fbc_supported_on_chipset(void)
>  
>  static void setup_fbc(void)
>  {
> -	int devid = intel_get_drm_devid(drm.fd);
> -
>  	if (!fbc_supported_on_chipset()) {
>  		igt_info("Can't test FBC: not supported on this chipset\n");
>  		return;
>  	}
>  
> -	/* Early Generations are not able to report compression status. */
> -	if (!AT_LEAST_GEN(devid, 7))
> -		opt.fbc_check_compression = false;
> -
>  	fbc.can_test = true;
>  
>  	fbc_setup_last_action();

-- 
Jani Nikula, Intel Open Source Graphics Center