Re: [igt-dev] [PATCH i-g-t 1/1] lib/igt_device_scan: clear igt_devs.devs_scanned in igt_devices_free

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 15 Sep 2022 06:57:39 -0700, Riana Tauro wrote:
>

Hi Riana,

> igt_devices_scan returns with empty list if devs_scanned
> is true and function is called after igt_devices_free
>
> clear igt_devs.devs_scanned in igt_devices_free.

The patch seems reasonable but could you please describe where you saw this
issue? It seems 'igt_devices_scan(true)' (called with force == true) will
get past this issue. Not too familiar with igt_devices_scan() usage so
copying some more people.

Also I am not sure why igt_devices_scan() doesn't simply do this:

void igt_devices_scan(bool force)
{
	if (force && igt_devs.devs_scanned) {
		igt_devices_free();

		/* Not needed after this patch */
		igt_devs.devs_scanned = false;
	}



Thanks.
--
Ashutosh


>
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> ---
>  lib/igt_device_scan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index eb6b45b8..e7c05d5c 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -1030,6 +1030,7 @@ void igt_devices_free(void)
>		igt_device_free(dev);
>		free(dev);
>	}
> +	igt_devs.devs_scanned = false;
>  }
>
>  /**
> --
> 2.25.1
>