From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E101389056
 for <igt-dev@lists.freedesktop.org>; Tue, 16 Nov 2021 16:44:39 +0000 (UTC)
Date: Tue, 16 Nov 2021 08:44:38 -0800
Message-ID: <87tugcvymh.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <83d2ed11-da5d-0760-23a8-b6e5fca0a14d@linux.intel.com>
References: <20211022061245.1166638-1-priyanka.dandamudi@intel.com>
 <20211022061245.1166638-3-priyanka.dandamudi@intel.com>
 <87h7d584kw.wl-ashutosh.dixit@intel.com>
 <83d2ed11-da5d-0760-23a8-b6e5fca0a14d@linux.intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t v2 2/3] i915/gem_engine_topology: Add
 compute class
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

On Tue, 16 Nov 2021 02:19:21 -0800, Tvrtko Ursulin wrote:
> >> diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
> >> index 4e497a5c..729f42b0 100644
> >> --- a/lib/i915/gem_engine_topology.c
> >> +++ b/lib/i915/gem_engine_topology.c
> >> @@ -130,6 +130,7 @@ static const char *class_names[] = {
> >>	[I915_ENGINE_CLASS_COPY]	  = "bcs",
> >>	[I915_ENGINE_CLASS_VIDEO]	  = "vcs",
> >>	[I915_ENGINE_CLASS_VIDEO_ENHANCE] = "vecs",
> >> +	[I915_ENGINE_CLASS_COMPUTE]       = "ccs",
>
> When are the i915 patches planned to appear?
>
> Asking since there are user requests to add compute engine support to
> intel_gpu_top and I am a bit unsure of the plans, given no platform
> currently exports the engine but IGT code apparently went in.

I understand CCS patches have been posted but are now blocked on adequate
IGT test coverage. Maybe it's ok to add CCS support to IGT intel_gpu_top
first as long as we are using the engine query (CCS is absent from legacy
engines) since the kernel will not return CCS?