From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E78989CF4 for ; Mon, 9 Aug 2021 20:29:34 +0000 (UTC) Date: Mon, 09 Aug 2021 13:29:32 -0700 Message-ID: <87tujy1hw3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210809130533.27759-54-zbigniew.kempczynski@intel.com> References: <20210809130533.27759-1-zbigniew.kempczynski@intel.com> <20210809130533.27759-54-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t v5 53/65] tests/i915_module_load: Adopt to use allocator List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org List-ID: On Mon, 09 Aug 2021 06:05:21 -0700, Zbigniew Kempczy=F1ski wrote: > > @@ -126,6 +144,9 @@ static void store_all(int i915) > gem_read(i915, obj[0].handle, 0, engines, nengine * sizeof(engines[0])); > gem_close(i915, obj[0].handle); > intel_ctx_destroy(i915, ctx); > + put_offset(ahnd, obj[0].handle); > + put_offset(ahnd, obj[1].handle); > + put_ahnd(ahnd); Maybe skip put_offset since we are doing put_ahnd anyway? Otherwise, Reviewed-by: Ashutosh Dixit