Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH] tests/intel/xe_oa: Add test to ensure entire report has landed
Date: Thu, 27 Aug 2026 16:07:14 -0700	[thread overview]
Message-ID: <87v78vcgd9.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20260826044209.1498337-2-umesh.nerlige.ramappa@intel.com>

On Tue, 25 Aug 2026 21:42:10 -0700, Umesh Nerlige Ramappa wrote:
>

Hi Umesh,

> When running the load helper with a fast oa_exponent, sometimes the OA
> reports land out of order. Ensure that the kernel fix for such issues is
> working by configuring all OA counters and checking validity of the full
> report.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> v2:
> - add a comment on event definitions
> - rename report checker for clarity
> - remove unnecessary spaces
> - u32s in one line
> - s/576/report_size
> ---
>  tests/intel/xe_oa.c | 217 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 217 insertions(+)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 9ebb18690ec7..58e50bb182a6 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -336,6 +336,88 @@ static struct oa_format lnl_oa_formats[XE_OA_FORMAT_MAX] = {
>		.bc_report = 0 },
>  };
>
> +/*
> + * test_oa_full defines only 2 events:
> + *
> + * 3e00 is "Number of GPU (gt) clock cycles at every clock period"
> + * 7e00 is "Number of GPU (gt) clock cycles at every other clock period"
> + *

Can you please also add here in the comment that we expect all counters in
a report to be non-zero with this metric set (or reg/val pairs).

Anyway, this test is failing in pre-merge CI, so let's see what we end up
with once we fix that issue. I'll hold the R-b till we have a working test.

Thanks.
--
Ashutosh

  parent reply	other threads:[~2026-08-27 23:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26  4:42 [PATCH] tests/intel/xe_oa: Add test to ensure entire report has landed Umesh Nerlige Ramappa
2026-08-26  5:35 ` ✓ Xe.CI.BAT: success for tests/intel/xe_oa: Add test to ensure entire report has landed (rev2) Patchwork
2026-08-26  5:41 ` ✓ i915.CI.BAT: " Patchwork
2026-08-26  6:53 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-01 23:06   ` Umesh Nerlige Ramappa
2026-09-01 23:20     ` Dixit, Ashutosh
2026-08-26  8:31 ` ✗ i915.CI.Full: " Patchwork
2026-08-27 23:07 ` Dixit, Ashutosh [this message]
2026-08-27 23:36   ` [PATCH] tests/intel/xe_oa: Add test to ensure entire report has landed Umesh Nerlige Ramappa
2026-09-01 23:16     ` Umesh Nerlige Ramappa
  -- strict thread matches above, loose matches on Subject: below --
2026-08-21 17:58 Umesh Nerlige Ramappa
2026-08-25  1:56 ` Dixit, Ashutosh
2026-08-26  4:29   ` Umesh Nerlige Ramappa
2026-08-26 15:04     ` Dixit, Ashutosh
2026-08-26 23:23       ` Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v78vcgd9.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox