From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 35C166E03E
 for <igt-dev@lists.freedesktop.org>; Sun,  9 Feb 2020 00:42:00 +0000 (UTC)
Date: Sat, 08 Feb 2020 16:41:59 -0800
Message-ID: <87v9ogwq08.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <87a75y501o.wl-ashutosh.dixit@intel.com>
References: <20200131173109.12527-1-ramalingam.c@intel.com>
 <20200131173109.12527-6-ramalingam.c@intel.com>
 <87a75y501o.wl-ashutosh.dixit@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Subject: Re: [igt-dev] [PATCH i-g-t 5/9] tests/kms_psr: Skip tests on
 mmap_gtt, if no mappable aperture
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: igt-dev <igt-dev@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 03 Feb 2020 22:38:59 -0800, Dixit, Ashutosh wrote:
>
> On Fri, 31 Jan 2020 09:31:05 -0800, Ramalingam C wrote:
> >
> > Due to non availability of the mappable aperture on discrete GPUs,
> > skip the tests specific to mmap_gtt
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > ---
> >  tests/kms_psr.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> > index d9be87d927b2..13ed02f46ac4 100644
> > --- a/tests/kms_psr.c
> > +++ b/tests/kms_psr.c
> > @@ -270,6 +270,7 @@ static void run_test(data_t *data)
> >		expected = "GREEN";
> >		break;
> >	case MMAP_GTT:
> > +		gem_require_mappable_ggtt(data->drm_fd);
> >		ptr = gem_mmap__gtt(data->drm_fd, handle, data->mod_size,
> >				    PROT_WRITE);
> >		gem_set_domain(data->drm_fd, handle,
>
> This test is actually using tiling (using LOCAL_I915_FORMAT_MOD_X_TILED) so
> probably more than this needs to be skipped?

Sorry, my earlier assessment was incorrect:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev