From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_pipe_control_store_loop: Limit runtime
Date: Mon, 27 Jan 2020 11:58:39 +0200 [thread overview]
Message-ID: <87v9oxmd9s.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200127085123.2229746-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Use a runtime limit, not a fixed amount of work, so that it doesn't take
> several hundred seconds on the slower machines.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> tests/i915/gem_pipe_control_store_loop.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/gem_pipe_control_store_loop.c b/tests/i915/gem_pipe_control_store_loop.c
> index b8a21d780..9330a47c8 100644
> --- a/tests/i915/gem_pipe_control_store_loop.c
> +++ b/tests/i915/gem_pipe_control_store_loop.c
> @@ -62,13 +62,13 @@ uint32_t devid;
>
> /* Like the store dword test, but we create new command buffers each time */
> static void
> -store_pipe_control_loop(bool preuse_buffer)
> +store_pipe_control_loop(bool preuse_buffer, int timeout)
> {
> int i, val = 0;
> uint32_t *buf;
> drm_intel_bo *target_bo;
>
> - for (i = 0; i < SLOW_QUICK(0x10000, 4); i++) {
> + igt_until_timeout(timeout) {
> /* we want to check tlb consistency of the pipe_control target,
> * so get a new buffer every time around */
> target_bo = drm_intel_bo_alloc(bufmgr, "target bo", 4096, 4096);
> @@ -182,10 +182,10 @@ igt_main
> }
>
> igt_subtest("fresh-buffer")
> - store_pipe_control_loop(false);
> + store_pipe_control_loop(false, 2);
>
> igt_subtest("reused-buffer")
> - store_pipe_control_loop(true);
> + store_pipe_control_loop(true, 2);
>
> igt_fixture {
> intel_batchbuffer_free(batch);
> --
> 2.25.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-27 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 8:51 [igt-dev] [PATCH i-g-t] i915/gem_pipe_control_store_loop: Limit runtime Chris Wilson
2020-01-27 9:58 ` Mika Kuoppala [this message]
2020-01-27 11:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9oxmd9s.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox